[fix](compaction) fix mismatch between segment key and value column rows during compaction#37960
Merged
dataroaring merged 7 commits intoapache:masterfrom Jul 22, 2024
Merged
Conversation
…ows during compaction
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40049 ms |
TPC-DS: Total hot run time: 173552 ms |
ClickBench: Total hot run time: 30.82 s |
dataroaring
reviewed
Jul 17, 2024
| } | ||
| // when splitting segment, need to make rows align between key columns and value columns | ||
| if (num_rows_written + limit >= num_rows_key_group && | ||
| _cur_writer_idx < _segment_writers.size() - 1) { |
Contributor
There was a problem hiding this comment.
to_written = num_rows_written + limit >= num_rows_key_group ? num_rows_key_group - num_rows_written : limit;
_segment_writers[_cur_writer_idx]->append_block(block, start_offset, to_written);
start_offset += to_written;
limit -= to_written;
if (limit > 0) {
++_cur_writer_idx;
// switch to next writer
RETURN_IF_ERROR(_segment_writers[_cur_writer_idx]->init(col_ids, is_key));
num_rows_written = 0;
num_rows_key_group = _segment_writers[_cur_writer_idx]->row_count();
}
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
2 similar comments
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
Author
|
run performance |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Yukang-Lian
approved these changes
Jul 20, 2024
github-actions
bot
removed
the
approved
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Jul 24, 2024
…ows during compaction (#37960) When a block is splitted to 3 segments, old code just handles 2 and the last is overlowed.
gavinchou
pushed a commit
that referenced
this pull request
Jul 25, 2024
#37960 introduces this problem
dataroaring
pushed a commit
that referenced
this pull request
Jul 27, 2024
#37960 introduces this problem
luwei16
added a commit
to luwei16/Doris
that referenced
this pull request
Aug 4, 2024
…ows during compaction (apache#37960) When a block is splitted to 3 segments, old code just handles 2 and the last is overlowed.
luwei16
added a commit
to luwei16/Doris
that referenced
this pull request
Aug 4, 2024
… compaction (apache#38251) apache#37960 introduced this issue
luwei16
added a commit
to luwei16/Doris
that referenced
this pull request
Aug 4, 2024
…38356) apache#37960 introduces this problem
dataroaring
pushed a commit
that referenced
this pull request
Aug 5, 2024
luwei16
added a commit
to luwei16/Doris
that referenced
this pull request
Aug 13, 2024
…ows during compaction (apache#37960) When a block is splitted to 3 segments, old code just handles 2 and the last is overlowed.
luwei16
added a commit
to luwei16/Doris
that referenced
this pull request
Aug 13, 2024
… compaction (apache#38251) apache#37960 introduced this issue
luwei16
added a commit
to luwei16/Doris
that referenced
this pull request
Aug 13, 2024
…38356) apache#37960 introduces this problem
dataroaring
pushed a commit
that referenced
this pull request
Aug 14, 2024
Closed
GoGoWen
pushed a commit
to GoGoWen/incubator-doris
that referenced
this pull request
Aug 27, 2024
…ows during compaction (apache#37960) (apache#38251) (apache#38356) (apache#39263) pick master apache#37960 apache#38251 apache#38356
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a block is splitted to 3 segments, old code just handles 2 and the last is overlowed.