[Pick](Variant) pick some fix#37926
Merged
xiaokang merged 9 commits intoapache:branch-3.0from Jul 17, 2024
Merged
Conversation
…` to limit tablets size for remote schema fetch (apache#37217) Describing tables with many partitions and tablets can cause high CPU usage. To mitigate this, we estimate and pick sample tablets for schema fetch, reducing the overall cost.
…ud mode (apache#37557) 1. In cloud mode the updated rowset meta after `rowset->merge_rowset_meta` in `BaseTablet::update_delete_bitmap` will be lost in `update_tmp_rowset`.So in order to keep the latest schema we should keep schema in update_tmp_rowset 2. cloud tablet should also do copy_without_variant_extracted_columns
…t column (apache#37674) …t column Eg. segment 1 has no variant columns and fill the dst with default value, which the variant columns's root is type nothing with n rows(not finalized), then reading segment2 with the none finalized variant column will lead to nullptr in `obj.get_root();`
…he#37839) `finalize` may change the inner data structure in ColumnObject, and lead to heap use after free in some scenario ## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
eldenmoon
requested review from
CalvinKirs,
dataroaring,
gavinchou,
morningman and
platoneko
as code owners
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
eldenmoon
changed the title
Member
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| if (rowset_meta.has_variant_type_in_schema()) { | ||
| write_schema_dict(code, msg, instance_id, txn.get(), &rowset_meta); | ||
| if (code != MetaServiceCode::OK) return; |
Contributor
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
Suggested change
| if (code != MetaServiceCode::OK) return; | |
| if (code != MetaServiceCode::OK) { return; | |
| } |
query like ``` select a, `__DORIS_DELETE_SIGN__` from `test_tbl` WHERE k = '1111111' ``` will not contain project list on top of OlapScanNode, so for short circuit queries, we should use output exprs on top of plan fragment. ``` +----------------------------------------------------------------------------------------------------------------------------+ | Explain String(Nereids Planner) | +----------------------------------------------------------------------------------------------------------------------------+ | PLAN FRAGMENT 0 | | OUTPUT EXPRS: | | k1[#0] | | k2[#1] | | k3[apache#2] | | k4[apache#3] | | k5[apache#4] | | k6[apache#5] | | k7[apache#6] | | k8[apache#7] | | k9[apache#8] | | k10[apache#9] | | k11[apache#10] | | k12[apache#11] | | new_column0[apache#12] | | new_column1[apache#13] | | __DORIS_DELETE_SIGN__[apache#14] | | PARTITION: UNPARTITIONED | | | | HAS_COLO_PLAN_NODE: false | | | | VRESULT SINK | | MYSQL_PROTOCAL | | | | 1:VEXCHANGE | | offset: 0 | | distribute expr lists: k1[#0], k2[#1], k3[apache#2] | | | | PLAN FRAGMENT 1 | | | | PARTITION: HASH_PARTITIONED: k1[#0], k2[#1], k3[apache#2] | | | | HAS_COLO_PLAN_NODE: false | | | | STREAM DATA SINK | | EXCHANGE ID: 01 | | UNPARTITIONED | | | | 0:VOlapScanNode(149) | | TABLE: regression_test_serving_p0.tbl_point_query0(tbl_point_query0), PREAGGREGATION: ON | | PREDICATES: (k1[#0] = 1231) AND (k2[#1] = 119291.110000000) AND (k3[apache#2] = 'ddd') AND (__DORIS_DELETE_SIGN__[apache#14] = 0) | | partitions=1/1 (tbl_point_query0) | | tablets=1/1, tabletList=13203 | | cardinality=0, avgRowSize=0.0, numNodes=1 | | pushAggOp=NONE | | SHORT-CIRCUIT | | | | | | Statistics | | planed with unknown column statistics | +----------------------------------------------------------------------------------------------------------------------------+ ```
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#37674
#37839
#37883
#37857
#37794
#37640
#37557
#37217
#37121