Skip to content

[fix](function) fix core when input not null array in foreach functio…#37798

Merged
yiguolei merged 1 commit intoapache:branch-2.1from
Mryange:branch-2.1
Jul 16, 2024
Merged

[fix](function) fix core when input not null array in foreach functio…#37798
yiguolei merged 1 commit intoapache:branch-2.1from
Mryange:branch-2.1

Conversation

@Mryange
Copy link
Copy Markdown
Contributor

@Mryange Mryange commented Jul 15, 2024

Proposed changes

#37349
error code

return creator_without_type::create<AggregateFunctionForEach>(transform_arguments, true,
                                                                      nested_function);

"transform_arguments is an internal type of array. All internal types of the array are null, so an array that is not null was mistakenly treated as a null array."

Proposed changes

Issue Number: close #xxx

apache#37349)

## Proposed changes

error code
```C++
return creator_without_type::create<AggregateFunctionForEach>(transform_arguments, true,
                                                                      nested_function);
```
"transform_arguments is an internal type of array. All internal types of
the array are null, so an array that is not null was mistakenly treated
as a null array."
@doris-robot
Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Mryange
Copy link
Copy Markdown
Contributor Author

Mryange commented Jul 15, 2024

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.54% (9259/25337)
Line Coverage: 28.06% (75651/269586)
Region Coverage: 26.88% (38900/144702)
Branch Coverage: 23.61% (19753/83664)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f58fd04dc0b4645e6e5e0a4ec93ca615f64486ae_f58fd04dc0b4645e6e5e0a4ec93ca615f64486ae/report/index.html

@yiguolei yiguolei merged commit e64f299 into apache:branch-2.1 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants