[fix](Nereids) Refactor character conversion to use Java 8's grammar#37773
Closed
keanji-x wants to merge 1 commit intoapache:masterfrom
Closed
[fix](Nereids) Refactor character conversion to use Java 8's grammar#37773keanji-x wants to merge 1 commit intoapache:masterfrom
keanji-x wants to merge 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39967 ms |
TPC-DS: Total hot run time: 172980 ms |
ClickBench: Total hot run time: 31.33 s |
morrySnow
previously approved these changes
Jul 15, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
run buildall |
TPC-H: Total hot run time: 40154 ms |
TPC-DS: Total hot run time: 173077 ms |
ClickBench: Total hot run time: 30.8 s |
Contributor
|
run external |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39764 ms |
TPC-DS: Total hot run time: 173882 ms |
ClickBench: Total hot run time: 30.41 s |
Contributor
|
run cloud_p1 |
Contributor
|
run buildall |
TPC-H: Total hot run time: 39557 ms |
TPC-DS: Total hot run time: 173929 ms |
ClickBench: Total hot run time: 31.54 s |
morrySnow
reviewed
Jul 16, 2024
| if (altValue != null && altValue.length() > 0) { | ||
| try { | ||
| return Character.toString((char) (Byte.parseByte(altValue) + 256) % 256); | ||
| return String.valueOf((char) (Byte.parseByte(altValue) + 256) % 256); |
Contributor
There was a problem hiding this comment.
Suggested change
| return String.valueOf((char) (Byte.parseByte(altValue) + 256) % 256); | |
| return Character.toString((char) ((Byte.parseByte(altValue) + 256) % 256)); |
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 40575 ms |
TPC-DS: Total hot run time: 173908 ms |
morrySnow
previously approved these changes
Jul 17, 2024
ClickBench: Total hot run time: 30.58 s |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
englefly
reviewed
Jul 17, 2024
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 40104 ms |
TPC-DS: Total hot run time: 173499 ms |
ClickBench: Total hot run time: 30.44 s |
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40022 ms |
TPC-DS: Total hot run time: 174484 ms |
ClickBench: Total hot run time: 30.66 s |
Contributor
|
run p0 |
keanji-x
changed the title
keanji-x
force-pushed
the
fix_grammar
branch
2 times, most recently
from
c8e68f3 to
2149d9c
Compare
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
intro by #37638
Update character to string conversion logic to leverage Java 8's String.valueOf() method, replacing the older Character.toString(). This change improves code readability and aligns with modern Java practices while maintaining existing functionality.