[fix](MoW) fix MoW & segcompaction conflict on cache of temp segment#37760
Merged
dataroaring merged 1 commit intoapache:masterfrom Jul 16, 2024
Merged
Conversation
MoW will update delete bitmap during load, and the page cache could be modified by segcompaction. Disable page cache touchs when doing segcompaction could solve this problem. Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 39755 ms |
TPC-DS: Total hot run time: 173469 ms |
ClickBench: Total hot run time: 30.76 s |
Contributor
Author
|
run external |
freemandealer
added a commit
to freemandealer/doris
that referenced
this pull request
Jul 16, 2024
…(pick apache#37760) MoW will update delete bitmap during load, and the page cache could be modified by segcompaction. Disable page cache touchs when doing segcompaction could solve this problem. Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
…pache#37760) MoW will update delete bitmap during load, and the page cache could be modified by segcompaction. Disable page cache touchs when doing segcompaction could solve this problem. ## Proposed changes Issue Number: close #xxx <!--Describe your changes.--> Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
…37760) MoW will update delete bitmap during load, and the page cache could be modified by segcompaction. Disable page cache touchs when doing segcompaction could solve this problem. ## Proposed changes Issue Number: close #xxx <!--Describe your changes.--> Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
dataroaring
pushed a commit
that referenced
this pull request
Jul 18, 2024
…(pick #37760) (#37938) MoW will update delete bitmap during load, and the page cache could be modified by segcompaction. Disable page cache touchs when doing segcompaction could solve this problem. ## Proposed changes Issue Number: close #xxx <!--Describe your changes.--> Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
dataroaring
pushed a commit
to dataroaring/incubator-doris
that referenced
this pull request
Aug 7, 2024
…pache#37760) MoW will update delete bitmap during load, and the page cache could be modified by segcompaction. Disable page cache touchs when doing segcompaction could solve this problem. ## Proposed changes Issue Number: close #xxx <!--Describe your changes.--> Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
dataroaring
added a commit
that referenced
this pull request
Aug 7, 2024
#38992) …(#37760) MoW will update delete bitmap during load, and the page cache could be modified by segcompaction. Disable page cache touchs when doing segcompaction could solve this problem. Signed-off-by: freemandealer <freeman.zhang1992@gmail.com> Co-authored-by: zhengyu <freeman.zhang1992@gmail.com>
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…(pick apache#37760) (apache#37938) MoW will update delete bitmap during load, and the page cache could be modified by segcompaction. Disable page cache touchs when doing segcompaction could solve this problem. ## Proposed changes Issue Number: close #xxx <!--Describe your changes.--> Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MoW will update delete bitmap during load, and the page cache could be modified by segcompaction. Disable page cache touchs when doing segcompaction could solve this problem.
Proposed changes
Issue Number: close #xxx