[fix](stacktrace) Add conf enable_stacktrace#37713
Merged
yiguolei merged 10 commits intoapache:masterfrom Jul 16, 2024
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40024 ms |
TPC-DS: Total hot run time: 173055 ms |
ClickBench: Total hot run time: 30.63 s |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40067 ms |
TPC-DS: Total hot run time: 173872 ms |
ClickBench: Total hot run time: 30.84 s |
xinyiZzz
force-pushed
the
20240712_fix_stack
branch
from
6d08a61 to
1a47d71
Compare
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39977 ms |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39935 ms |
TPC-DS: Total hot run time: 172944 ms |
ClickBench: Total hot run time: 31.81 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40053 ms |
TPC-DS: Total hot run time: 173615 ms |
ClickBench: Total hot run time: 30.88 s |
Contributor
Author
|
run buildall |
1 similar comment
Contributor
|
run buildall |
TPC-H: Total hot run time: 40145 ms |
TPC-DS: Total hot run time: 174158 ms |
ClickBench: Total hot run time: 30.76 s |
yiguolei
approved these changes
Jul 16, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
zhiqiang-hhhh
approved these changes
Jul 16, 2024
jacktengg
reviewed
Jul 16, 2024
| #ifndef ENABLE_STACKTRACE | ||
| LOG(INFO) << stack_trace_st.to_string(); | ||
| #endif | ||
| if (!doris::config::enable_stacktrace) { |
Contributor
There was a problem hiding this comment.
should be if (doris::config::enable_stacktrace) ?
Contributor
Author
There was a problem hiding this comment.
No, it is if (!doris::config::enable_stacktrace)
u can see before it was #ifndef ENABLE_STACKTRACE
Contributor
There was a problem hiding this comment.
执行到这里说明触发了概率性AllocateFailed，为了确保这里有且仅有一个堆栈，加了一个check，如果编译代码的时候不打堆栈，那这里手动获取堆栈打印到日志里。
Gabriel39
approved these changes
Jul 16, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
`enable_stacktrace` if false, turn off all stacktrace
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
`enable_stacktrace` if false, turn off all stacktrace
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable_stacktraceif false, turn off all stacktrace