[fix](jni_connector) fix that be core when jni_connector open fails#37697
Merged
morningman merged 2 commits intoapache:masterfrom Jul 14, 2024
Merged
[fix](jni_connector) fix that be core when jni_connector open fails#37697morningman merged 2 commits intoapache:masterfrom
morningman merged 2 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40159 ms |
TPC-DS: Total hot run time: 175289 ms |
ClickBench: Total hot run time: 30.79 s |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40266 ms |
TPC-DS: Total hot run time: 172786 ms |
ClickBench: Total hot run time: 30.82 s |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
hello-stephen
approved these changes
Jul 14, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
…pache#37697) Here are two problems: 1. `appendDataTimeNs` will be `NULL` if TrinoConnector open fails before call to `parseRequiredTypes` 2. It does not catch exception in method `get_statistics()` and this exception is not caught until `close()` method. Therefore, it will cause BE core dump in `JniConnector::close()` at `LOG(FATAL)`
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
…37697) Here are two problems: 1. `appendDataTimeNs` will be `NULL` if TrinoConnector open fails before call to `parseRequiredTypes` 2. It does not catch exception in method `get_statistics()` and this exception is not caught until `close()` method. Therefore, it will cause BE core dump in `JniConnector::close()` at `LOG(FATAL)`
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Here are two problems:
appendDataTimeNswill beNULLif TrinoConnector open fails before call toparseRequiredTypesget_statistics()and this exception is not caught untilclose()method. Therefore, it will cause BE core dump inJniConnector::close()atLOG(FATAL)