(cloud-merge) Support to abort txn when coordinate be restart and do schema change#37669
Merged
gavinchou merged 10 commits intoapache:masterfrom Jul 30, 2024
Merged
(cloud-merge) Support to abort txn when coordinate be restart and do schema change#37669gavinchou merged 10 commits intoapache:masterfrom
gavinchou merged 10 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Lchangliang
force-pushed
the
dev-0710-txn
branch
from
ca83c30 to
166a237
Compare
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| #include <gen_cpp/cloud.pb.h> |
Contributor
There was a problem hiding this comment.
warning: 'gen_cpp/cloud.pb.h' file not found [clang-diagnostic-error]
#include <gen_cpp/cloud.pb.h>
^
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39787 ms |
TPC-DS: Total hot run time: 173334 ms |
ClickBench: Total hot run time: 30.29 s |
Lchangliang
force-pushed
the
dev-0710-txn
branch
from
5db13f0 to
70332d6
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39994 ms |
TPC-DS: Total hot run time: 172919 ms |
ClickBench: Total hot run time: 30.32 s |
Contributor
Author
|
run cloud_p0 |
gavinchou
requested changes
Jul 18, 2024
luwei16
reviewed
Jul 22, 2024
Lchangliang
force-pushed
the
dev-0710-txn
branch
from
70332d6 to
caa19ef
Compare
Contributor
Author
|
run buildall |
2 similar comments
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40310 ms |
TPC-DS: Total hot run time: 173016 ms |
ClickBench: Total hot run time: 30.66 s |
Contributor
Author
|
run external |
gavinchou
requested changes
Jul 28, 2024
Lchangliang
force-pushed
the
dev-0710-txn
branch
from
93ad64b to
7bff4b6
Compare
Lchangliang
changed the title
Lchangliang
force-pushed
the
dev-0710-txn
branch
from
7bff4b6 to
0be9160
Compare
Contributor
Author
|
run buildall |
gavinchou
reviewed
Jul 29, 2024
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41733 ms |
TPC-DS: Total hot run time: 171104 ms |
ClickBench: Total hot run time: 29.87 s |
gavinchou
approved these changes
Jul 30, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
luwei16
approved these changes
Jul 30, 2024
dataroaring
pushed a commit
that referenced
this pull request
Aug 11, 2024
…schema change (#37669) When do schema change, it will check whether transactions of the given database which txnId is less than 'watershedTxnId' are finished. If is not, schema change will be waiting. When the coordinator restart (whatever fe/be), the txn belong the cooridinator will be hang until timeout. So we need to abort it in time. There are two optimizations. 1. Check BE's lastStartTime when get it heart beat. If current lastStartTime is large than lastStartTime in fe memory. Abort all the hang txns belong this BE. 2. Check conflict txns when do schema change. If txns is failed (Maybe coordinator be/fe restart), abort it directly.
dataroaring
pushed a commit
that referenced
this pull request
Aug 16, 2024
…schema change (#37669) When do schema change, it will check whether transactions of the given database which txnId is less than 'watershedTxnId' are finished. If is not, schema change will be waiting. When the coordinator restart (whatever fe/be), the txn belong the cooridinator will be hang until timeout. So we need to abort it in time. There are two optimizations. 1. Check BE's lastStartTime when get it heart beat. If current lastStartTime is large than lastStartTime in fe memory. Abort all the hang txns belong this BE. 2. Check conflict txns when do schema change. If txns is failed (Maybe coordinator be/fe restart), abort it directly.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When do schema change, it will check whether transactions of the given database which txnId is less than 'watershedTxnId' are finished. If is not, schema change will be waiting.
When the coordinator restart (whatever fe/be), the txn belong the cooridinator will be hang until timeout. So we need to abort it in time.
There are two optimizations.