Skip to content

[feature](Recycler) Parallelize s3 delete operations and recycle_tablet #37630

Merged
gavinchou merged 1 commit intoapache:masterfrom
ByteYue:batch_delete_for_recycler
Jul 19, 2024
Merged

[feature](Recycler) Parallelize s3 delete operations and recycle_tablet #37630
gavinchou merged 1 commit intoapache:masterfrom
ByteYue:batch_delete_for_recycler

Conversation

@ByteYue
Copy link
Copy Markdown
Contributor

@ByteYue ByteYue commented Jul 10, 2024

Proposed changes

Previously the procedure of recycler instance is single-threaded, which is not full sufficiently parallel. And there exists many network IO operation. So this pr tries to spilt recycle tasks into different stage which can be parallel. And make the delete operations parallel.

@doris-robot
Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@ByteYue ByteYue force-pushed the batch_delete_for_recycler branch from cdeabe3 to 0d1bc2a Compare July 10, 2024 15:24
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread cloud/src/recycler/obj_storage_client.cpp
Comment thread cloud/src/recycler/util.h Outdated
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread cloud/test/recycler_test.cpp
Comment thread cloud/test/recycler_test.cpp Outdated
@ByteYue ByteYue force-pushed the batch_delete_for_recycler branch from 217d892 to a323207 Compare July 12, 2024 07:23
@ByteYue
Copy link
Copy Markdown
Contributor Author

ByteYue commented Jul 12, 2024

run buildall

@ByteYue ByteYue changed the title [feature-wip](Recycler) Parallelize s3 delete operations and recycle_tablet [feature](Recycler) Parallelize s3 delete operations and recycle_tablet Jul 12, 2024
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread cloud/test/util_test.cpp
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread cloud/test/util_test.cpp
@ByteYue
Copy link
Copy Markdown
Contributor Author

ByteYue commented Jul 12, 2024

run buildall

@ByteYue ByteYue force-pushed the batch_delete_for_recycler branch from 13f3b11 to 7dd23dc Compare July 15, 2024 10:48
@ByteYue
Copy link
Copy Markdown
Contributor Author

ByteYue commented Jul 15, 2024

run buildall

Comment thread cloud/src/recycler/s3_accessor.h Outdated
Comment thread cloud/src/recycler/s3_accessor.cpp Outdated
Comment thread cloud/src/recycler/recycler.h Outdated
Comment thread cloud/src/recycler/util.h Outdated
Comment thread cloud/src/recycler/util.h
Comment thread cloud/src/recycler/obj_storage_client.h Outdated
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread cloud/src/recycler/sync_executor.h
Comment thread cloud/src/recycler/util.h
@ByteYue
Copy link
Copy Markdown
Contributor Author

ByteYue commented Jul 16, 2024

run buildall

@ByteYue ByteYue force-pushed the batch_delete_for_recycler branch from 19c6e5b to 4baa42f Compare July 16, 2024 10:22
@ByteYue
Copy link
Copy Markdown
Contributor Author

ByteYue commented Jul 16, 2024

run buildall

@ByteYue ByteYue force-pushed the batch_delete_for_recycler branch 4 times, most recently from 09d8af2 to f605509 Compare July 17, 2024 08:24
@ByteYue
Copy link
Copy Markdown
Contributor Author

ByteYue commented Jul 17, 2024

run buildall

@ByteYue ByteYue force-pushed the batch_delete_for_recycler branch from f605509 to 2c12345 Compare July 18, 2024 03:00
@ByteYue ByteYue requested a review from platoneko July 18, 2024 03:00
@ByteYue
Copy link
Copy Markdown
Contributor Author

ByteYue commented Jul 18, 2024

run buildall

use atomic

use value
@ByteYue ByteYue force-pushed the batch_delete_for_recycler branch from 2c12345 to 6f5219d Compare July 19, 2024 07:50
@ByteYue
Copy link
Copy Markdown
Contributor Author

ByteYue commented Jul 19, 2024

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 19, 2024
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@gavinchou gavinchou merged commit 05b05bd into apache:master Jul 19, 2024
dataroaring pushed a commit that referenced this pull request Aug 16, 2024
…et (#37630)

Previously the procedure of recycler instance is single-threaded, which
is not full sufficiently parallel. And there exists many network IO
operation. So this pr tries to spilt recycle tasks into different stage
which can be parallel. And make the delete operations parallel.
@gavinchou gavinchou mentioned this pull request Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants