[feature](vault) Support alter storage vault stmt in FE#37606
Merged
gavinchou merged 1 commit intoapache:masterfrom Jul 29, 2024
Merged
[feature](vault) Support alter storage vault stmt in FE#37606gavinchou merged 1 commit intoapache:masterfrom
gavinchou merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39857 ms |
TPC-DS: Total hot run time: 173777 ms |
ClickBench: Total hot run time: 30.48 s |
712827e to
8801d07
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
8b0f1d0 to
9ea5790
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40568 ms |
TPC-DS: Total hot run time: 174317 ms |
ClickBench: Total hot run time: 30.37 s |
platoneko
requested changes
Jul 16, 2024
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40645 ms |
TPC-DS: Total hot run time: 173492 ms |
ClickBench: Total hot run time: 30.67 s |
platoneko
previously approved these changes
Jul 17, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
gavinchou
requested changes
Jul 17, 2024
Contributor
gavinchou
left a comment
There was a problem hiding this comment.
Pls add regression test for the new feature
3e99939 to
298784b
Compare
Contributor
Author
|
run feut |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40184 ms |
TPC-DS: Total hot run time: 173053 ms |
ClickBench: Total hot run time: 31.03 s |
298784b to
9ddb534
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40315 ms |
TPC-DS: Total hot run time: 173686 ms |
ClickBench: Total hot run time: 30.63 s |
gavinchou
approved these changes
Jul 29, 2024
Yukang-Lian
approved these changes
Jul 29, 2024
gavinchou
pushed a commit
that referenced
this pull request
Sep 10, 2024
Support alter storage vault stmt in FE. Currently only support alter s3 vault's ak and sk. For example ```sql alter storage vault s3_vault properties( "type" = "s3", "ak" = "new_ak" ); ```
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support alter storage vault stmt in FE. Currently only support alter s3 vault's ak and sk.
For example