[fix](merge-on-write) when full clone failed, duplicate key might occur (#37001)#37229
Merged
zhannngchen merged 1 commit intoapache:branch-2.1from Jul 3, 2024
Merged
Conversation
…ur (apache#37001) ## Proposed changes Issue Number: close #xxx introduced by apache#31268 full clone failure may produce duplicate keys in mow table the bug would be triggered in the following condition: 1. replica 0 miss version 2. replica 0 try to do full clone from other replicas 3. the full clone failed and the delete bitmap is overrided incorrectly 4. replica 0 try to do incremental clone again and this time the clone succeed 5. incremental clone can't fix the delete bitmap overrided by previous failed full clone 6. duplicate key occurred solution: for full clone, don't override the delete bitmap, use `merge()` method instead.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
cherry-pick #37001