[fix](HadoopLz4BlockCompression)Fixed the bug that HadoopLz4BlockCompression creates _decompressor every time it decompresses.#37187
Merged
morningman merged 1 commit intoapache:masterfrom Jul 4, 2024
Conversation
…ression creates _decompressor every time it decompresses.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #include <libdeflate.h> | ||
| #endif | ||
| #include <glog/log_severity.h> | ||
| #include <glog/logging.h> |
Contributor
There was a problem hiding this comment.
warning: duplicate include [readability-duplicate-include]
be/src/util/block_compression.cpp:27:
- #include <glog/log_severity.h>
- #include <glog/logging.h>
+ #include <glog/log_severity.h>
TPC-H: Total hot run time: 40690 ms |
TPC-DS: Total hot run time: 174715 ms |
ClickBench: Total hot run time: 30.42 s |
Contributor
Author
|
run p0 |
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
AshinGau
approved these changes
Jul 4, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
…ression creates _decompressor every time it decompresses. (#37187) ## Proposed changes Problem: HadoopLz4BlockCompression uses a singleton mode. Every time its decompression function is called, a new object will be created for its member variable _decompressor. In a multi-threaded scenario, new objects will be created for _decompressor at the same time. Fix method: During the construction phase of HadoopLz4BlockCompression, a new object is created for its member variable _decompressor. When calling the decompression function, there is no need to create a new object for _decompressor.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
HadoopLz4BlockCompression uses a singleton mode.
Every time its decompression function is called, a new object will be created for its member variable _decompressor. In a multi-threaded scenario, new objects will be created for _decompressor at the same time.
Fix method:
During the construction phase of HadoopLz4BlockCompression, a new object is created for its member variable _decompressor. When calling the decompression function, there is no need to create a new object for _decompressor.
Issue Number: close #xxx