[feat](nereids) support explain delete from clause#36782
Merged
englefly merged 1 commit intoapache:masterfrom Jul 1, 2024
Merged
[feat](nereids) support explain delete from clause#36782englefly merged 1 commit intoapache:masterfrom
englefly merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
morrySnow
reviewed
Jun 25, 2024
Contributor
morrySnow
left a comment
morrySnow
left a comment
There was a problem hiding this comment.
- delete from dup/agg table still cannot explain, and will throw wrong error message, we should handle it by throw right error message.
- add explain update case to ensure all dml is ok
englefly
force-pushed
the
explain-delete-from
branch
from
6dac736 to
2f81b9b
Compare
Contributor
Author
|
run buildall |
englefly
force-pushed
the
explain-delete-from
branch
from
2f81b9b to
7d8699e
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39338 ms |
TPC-DS: Total hot run time: 172807 ms |
ClickBench: Total hot run time: 30.37 s |
morrySnow
previously approved these changes
Jun 27, 2024
englefly
force-pushed
the
explain-delete-from
branch
from
7d8699e to
4333231
Compare
Contributor
Author
|
run buildall |
englefly
force-pushed
the
explain-delete-from
branch
from
4333231 to
c61547b
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39805 ms |
TPC-DS: Total hot run time: 169872 ms |
ClickBench: Total hot run time: 30.12 s |
Contributor
Author
|
run p0 |
1 similar comment
Contributor
Author
|
run p0 |
morrySnow
approved these changes
Jul 1, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
LiBinfeng-01
approved these changes
Jul 1, 2024
englefly
added a commit
to englefly/incubator-doris
that referenced
this pull request
Jul 1, 2024
## Proposed changes support explain like: explain delete from T where A=1 Issue Number: close #xxx <!--Describe your changes.--> (cherry picked from commit dc369cd)
dataroaring
pushed a commit
that referenced
this pull request
Jul 2, 2024
## Proposed changes support explain like: explain delete from T where A=1 Issue Number: close #xxx <!--Describe your changes.-->
dataroaring
pushed a commit
that referenced
this pull request
Aug 9, 2024
… in Nereids planner (#38751) ## Proposed changes 1. Fix nereids planner don't use partial update for delete statement on merge-on-write table introduced in #36782 2. add `IS_PARTIAL_UPDATE: true` in `OlapTableSink.getExplainString()` 3. don't convert the delete stmt to partial update if the table has cluster key.
dataroaring
pushed a commit
that referenced
this pull request
Aug 9, 2024
… in Nereids planner (#38751) ## Proposed changes 1. Fix nereids planner don't use partial update for delete statement on merge-on-write table introduced in #36782 2. add `IS_PARTIAL_UPDATE: true` in `OlapTableSink.getExplainString()` 3. don't convert the delete stmt to partial update if the table has cluster key.
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 14, 2024
… in Nereids planner (apache#38751) ## Proposed changes 1. Fix nereids planner don't use partial update for delete statement on merge-on-write table introduced in apache#36782 2. add `IS_PARTIAL_UPDATE: true` in `OlapTableSink.getExplainString()` 3. don't convert the delete stmt to partial update if the table has cluster key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
support explain like:
explain delete from T where A=1
Issue Number: close #xxx