[fix](inverted index) fixed in_list condition not indexed on pipelinex#36565
Merged
qidaye merged 1 commit intoapache:masterfrom Jun 21, 2024
Merged
[fix](inverted index) fixed in_list condition not indexed on pipelinex#36565qidaye merged 1 commit intoapache:masterfrom
qidaye merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| template <typename Derived> | ||
| template <PrimitiveType T> | ||
| Status ScanLocalState<Derived>::_normalize_binary_in_compound_predicate( | ||
| Status ScanLocalState<Derived>::_normalize_binary_compound_predicate( |
Contributor
There was a problem hiding this comment.
warning: function '_normalize_binary_compound_predicate' has cognitive complexity of 54 (threshold 50) [readability-function-cognitive-complexity]
Status ScanLocalState<Derived>::_normalize_binary_compound_predicate(
^Additional context
be/src/pipeline/exec/scan_operator.cpp:1044: +1, including nesting penalty of 0, nesting level increased to 1
if (TExprNodeType::BINARY_PRED == expr->node_type()) {
^be/src/pipeline/exec/scan_operator.cpp:1045: nesting level increased to 2
auto eq_checker = [](const std::string& fn_name) { return fn_name == "eq"; };
^be/src/pipeline/exec/scan_operator.cpp:1046: nesting level increased to 2
auto ne_checker = [](const std::string& fn_name) { return fn_name == "ne"; };
^be/src/pipeline/exec/scan_operator.cpp:1047: nesting level increased to 2
auto noneq_checker = [](const std::string& fn_name) {
^be/src/pipeline/exec/scan_operator.cpp:1048: +1
return fn_name != "ne" && fn_name != "eq" && fn_name != "eq_for_null";
^be/src/pipeline/exec/scan_operator.cpp:1056: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(_should_push_down_binary_predicate(
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/pipeline/exec/scan_operator.cpp:1056: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(_should_push_down_binary_predicate(
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/pipeline/exec/scan_operator.cpp:1059: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(_should_push_down_binary_predicate(
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/pipeline/exec/scan_operator.cpp:1059: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(_should_push_down_binary_predicate(
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/pipeline/exec/scan_operator.cpp:1062: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(_should_push_down_binary_predicate(
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/pipeline/exec/scan_operator.cpp:1062: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(_should_push_down_binary_predicate(
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/pipeline/exec/scan_operator.cpp:1065: +2, including nesting penalty of 1, nesting level increased to 2
if (eq_pdt == PushDownType::UNACCEPTABLE && ne_pdt == PushDownType::UNACCEPTABLE &&
^be/src/pipeline/exec/scan_operator.cpp:1065: +1
if (eq_pdt == PushDownType::UNACCEPTABLE && ne_pdt == PushDownType::UNACCEPTABLE &&
^be/src/pipeline/exec/scan_operator.cpp:1072: +2, including nesting penalty of 1, nesting level increased to 2
if (eq_pdt == PushDownType::ACCEPTABLE || ne_pdt == PushDownType::ACCEPTABLE ||
^be/src/pipeline/exec/scan_operator.cpp:1072: +1
if (eq_pdt == PushDownType::ACCEPTABLE || ne_pdt == PushDownType::ACCEPTABLE ||
^be/src/pipeline/exec/scan_operator.cpp:1074: +3, including nesting penalty of 2, nesting level increased to 3
if (value.data != nullptr) {
^be/src/pipeline/exec/scan_operator.cpp:1075: +4, including nesting penalty of 3, nesting level increased to 4
if constexpr (T == TYPE_CHAR || T == TYPE_VARCHAR || T == TYPE_STRING ||
^be/src/pipeline/exec/scan_operator.cpp:1075: +1
if constexpr (T == TYPE_CHAR || T == TYPE_VARCHAR || T == TYPE_STRING ||
^be/src/pipeline/exec/scan_operator.cpp:1078: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(_change_value_range<false>(
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/pipeline/exec/scan_operator.cpp:1078: +6, including nesting penalty of 5, nesting level increased to 6
RETURN_IF_ERROR(_change_value_range<false>(
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/pipeline/exec/scan_operator.cpp:1082: +1, nesting level increased to 4
} else {
^be/src/pipeline/exec/scan_operator.cpp:1083: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(_change_value_range<false>(
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/pipeline/exec/scan_operator.cpp:1083: +6, including nesting penalty of 5, nesting level increased to 6
RETURN_IF_ERROR(_change_value_range<false>(
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^| return Status::OK(); | ||
| } | ||
| } else { | ||
| vectorized::VInPredicate* pred = static_cast<vectorized::VInPredicate*>(expr); |
Contributor
There was a problem hiding this comment.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Suggested change
| vectorized::VInPredicate* pred = static_cast<vectorized::VInPredicate*>(expr); | |
| auto* pred = static_cast<vectorized::VInPredicate*>(expr); |
| } else { | ||
| vectorized::VInPredicate* pred = static_cast<vectorized::VInPredicate*>(expr); | ||
|
|
||
| vectorized::InState* state = reinterpret_cast<vectorized::InState*>( |
Contributor
There was a problem hiding this comment.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Suggested change
| vectorized::InState* state = reinterpret_cast<vectorized::InState*>( | |
| auto* state = reinterpret_cast<vectorized::InState*>( |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 39902 ms |
TPC-DS: Total hot run time: 172285 ms |
ClickBench: Total hot run time: 30.72 s |
xiaokang
changed the title
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 39739 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40533 ms |
TPC-DS: Total hot run time: 169640 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 30.14 s |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run p0 |
qidaye
previously approved these changes
Jun 20, 2024
Contributor
Author
|
run p0 |
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 40099 ms |
Contributor
Author
|
run performance |
TPC-H: Total hot run time: 39672 ms |
TPC-DS: Total hot run time: 173831 ms |
ClickBench: Total hot run time: 30.57 s |
xiaokang
changed the title
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
qidaye
approved these changes
Jun 21, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jun 21, 2024
zzzxl1993
added a commit
to zzzxl1993/doris
that referenced
this pull request
Jul 21, 2024
yiguolei
pushed a commit
that referenced
this pull request
Jul 25, 2024
dataroaring
added
dev/3.0.0-merged
dev/2.1.6-merged
and removed
dev/2.1.6-merged
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx