Skip to content

[opt](arena) lazy memory allocation in arena#36498

Merged
BiteTheDDDDt merged 18 commits intoapache:masterfrom
zhiqiang-hhhh:opt-arena
Jul 1, 2024
Merged

[opt](arena) lazy memory allocation in arena#36498
BiteTheDDDDt merged 18 commits intoapache:masterfrom
zhiqiang-hhhh:opt-arena

Conversation

@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor

@zhiqiang-hhhh zhiqiang-hhhh commented Jun 18, 2024

Arena should not allocate memory in this constructor.

After this pr merged, we shuold revert #36299

@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor Author

run buildall

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread be/src/vec/common/arena.h Outdated
@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

TPC-H: Total hot run time: 40363 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bf5a79c89b1cb1e02406e1b619c6e73ca69e5fc0, data reload: false

------ Round 1 ----------------------------------
q1	17999	4626	4441	4441
q2	3078	193	205	193
q3	10997	1124	1243	1124
q4	11181	773	854	773
q5	7569	2730	2722	2722
q6	224	137	137	137
q7	969	616	621	616
q8	9357	2085	2071	2071
q9	9062	6557	6544	6544
q10	8901	3747	3755	3747
q11	466	238	239	238
q12	414	232	222	222
q13	17765	3011	2968	2968
q14	281	209	219	209
q15	511	467	474	467
q16	524	396	384	384
q17	984	736	695	695
q18	8087	7552	7391	7391
q19	3363	1519	1541	1519
q20	663	314	330	314
q21	5000	3252	3295	3252
q22	386	337	336	336
Total cold run time: 117781 ms
Total hot run time: 40363 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4386	4233	4207	4207
q2	371	295	271	271
q3	2983	2783	2755	2755
q4	1869	1608	1671	1608
q5	5225	5298	5319	5298
q6	213	125	124	124
q7	2104	1693	1720	1693
q8	3204	3331	3326	3326
q9	8376	8302	8377	8302
q10	3897	3670	3641	3641
q11	596	492	487	487
q12	754	605	594	594
q13	17643	2987	2994	2987
q14	293	258	265	258
q15	518	481	473	473
q16	473	416	418	416
q17	1766	1500	1452	1452
q18	7722	7515	7315	7315
q19	1759	1481	1474	1474
q20	1981	1777	1764	1764
q21	4836	4668	4710	4668
q22	594	553	543	543
Total cold run time: 71563 ms
Total hot run time: 53656 ms

@doris-robot
Copy link
Copy Markdown

TPC-DS: Total hot run time: 172719 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bf5a79c89b1cb1e02406e1b619c6e73ca69e5fc0, data reload: false

query1	939	381	382	381
query2	6450	2487	2310	2310
query3	6652	204	208	204
query4	19112	17364	17172	17172
query5	4146	484	470	470
query6	252	166	161	161
query7	4588	305	293	293
query8	299	283	275	275
query9	8569	2443	2437	2437
query10	589	299	300	299
query11	10493	10077	10056	10056
query12	133	85	83	83
query13	1635	367	365	365
query14	10182	7497	6761	6761
query15	223	188	182	182
query16	7870	269	261	261
query17	1930	542	518	518
query18	1959	276	272	272
query19	191	183	150	150
query20	91	82	82	82
query21	208	130	121	121
query22	4350	4150	4056	4056
query23	33689	33116	33206	33116
query24	11171	2814	2786	2786
query25	625	352	353	352
query26	1473	152	159	152
query27	2959	328	316	316
query28	7474	2066	2092	2066
query29	970	630	596	596
query30	271	147	150	147
query31	942	757	737	737
query32	96	54	55	54
query33	768	285	278	278
query34	982	471	463	463
query35	718	613	603	603
query36	1054	926	930	926
query37	157	75	70	70
query38	2928	2770	2753	2753
query39	858	814	805	805
query40	222	120	125	120
query41	56	55	59	55
query42	119	105	100	100
query43	571	553	545	545
query44	1192	722	727	722
query45	222	157	168	157
query46	1081	740	728	728
query47	1889	1796	1797	1796
query48	365	295	287	287
query49	1133	404	409	404
query50	765	388	393	388
query51	6861	6699	6592	6592
query52	101	94	97	94
query53	363	290	291	290
query54	888	442	443	442
query55	75	74	75	74
query56	290	250	279	250
query57	1160	1095	1117	1095
query58	246	239	257	239
query59	3594	3201	3130	3130
query60	296	268	321	268
query61	93	92	89	89
query62	666	450	435	435
query63	314	289	298	289
query64	9270	2307	1780	1780
query65	3199	3192	3146	3146
query66	1234	352	332	332
query67	15531	15088	14966	14966
query68	4932	544	547	544
query69	590	416	377	377
query70	1157	1124	1155	1124
query71	447	275	275	275
query72	7138	5495	5756	5495
query73	764	334	331	331
query74	5966	5618	5514	5514
query75	3699	2646	2667	2646
query76	3427	834	909	834
query77	667	303	302	302
query78	10424	9895	9684	9684
query79	2358	520	508	508
query80	1383	489	465	465
query81	579	220	214	214
query82	762	102	102	102
query83	198	168	172	168
query84	272	89	87	87
query85	1457	293	287	287
query86	465	321	314	314
query87	3299	3074	3155	3074
query88	3713	2454	2438	2438
query89	466	381	373	373
query90	1799	195	191	191
query91	125	101	99	99
query92	61	49	48	48
query93	2900	528	501	501
query94	1181	188	189	188
query95	413	314	315	314
query96	587	280	267	267
query97	3190	3025	2994	2994
query98	237	203	202	202
query99	1234	854	817	817
Total cold run time: 275682 ms
Total hot run time: 172719 ms

@doris-robot
Copy link
Copy Markdown

ClickBench: Total hot run time: 30.6 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bf5a79c89b1cb1e02406e1b619c6e73ca69e5fc0, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.04	0.04
query4	1.69	0.07	0.08
query5	0.50	0.50	0.48
query6	1.14	0.72	0.72
query7	0.03	0.01	0.01
query8	0.05	0.04	0.05
query9	0.54	0.49	0.51
query10	0.52	0.55	0.54
query11	0.16	0.12	0.11
query12	0.14	0.12	0.12
query13	0.59	0.59	0.60
query14	0.76	0.78	0.77
query15	0.83	0.81	0.82
query16	0.37	0.36	0.36
query17	1.02	1.04	1.04
query18	0.21	0.22	0.25
query19	1.83	1.74	1.85
query20	0.02	0.01	0.01
query21	15.40	0.64	0.63
query22	4.06	7.26	1.85
query23	18.45	1.40	1.30
query24	2.44	0.22	0.21
query25	0.16	0.08	0.08
query26	0.26	0.17	0.18
query27	0.08	0.08	0.08
query28	13.25	1.01	0.99
query29	12.60	3.32	3.30
query30	0.26	0.06	0.07
query31	2.85	0.38	0.38
query32	3.27	0.47	0.46
query33	2.92	2.92	2.89
query34	17.10	4.48	4.43
query35	4.43	4.48	4.61
query36	0.64	0.46	0.49
query37	0.17	0.15	0.15
query38	0.16	0.14	0.15
query39	0.04	0.04	0.03
query40	0.18	0.14	0.15
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.05
Total cold run time: 109.67 s
Total hot run time: 30.6 s

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.46% (9003/24693)
Line Coverage: 28.02% (73804/263438)
Region Coverage: 27.50% (38342/139430)
Branch Coverage: 24.20% (19551/80788)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bf5a79c89b1cb1e02406e1b619c6e73ca69e5fc0_bf5a79c89b1cb1e02406e1b619c6e73ca69e5fc0/report/index.html

@zhiqiang-hhhh zhiqiang-hhhh force-pushed the opt-arena branch 2 times, most recently from 1ecef6c to 9fa96d2 Compare June 21, 2024 07:26
@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

ClickBench: Total hot run time: 30.56 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 378028095c275e9a1fe62a0a81ae409048800e9e, data reload: false

query1	0.04	0.03	0.03
query2	0.09	0.04	0.04
query3	0.22	0.05	0.05
query4	1.67	0.08	0.07
query5	0.51	0.49	0.48
query6	1.14	0.73	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.05
query9	0.55	0.50	0.48
query10	0.55	0.54	0.55
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.59	0.59	0.60
query14	0.77	0.78	0.78
query15	0.85	0.81	0.82
query16	0.37	0.34	0.37
query17	1.04	1.04	1.04
query18	0.23	0.24	0.27
query19	1.84	1.69	1.72
query20	0.01	0.00	0.01
query21	15.42	0.65	0.66
query22	4.62	6.28	1.85
query23	18.29	1.40	1.35
query24	2.13	0.22	0.21
query25	0.15	0.09	0.08
query26	0.28	0.18	0.18
query27	0.08	0.08	0.08
query28	13.25	1.03	1.00
query29	12.63	3.30	3.23
query30	0.26	0.06	0.06
query31	2.85	0.39	0.38
query32	3.29	0.46	0.47
query33	2.91	2.87	2.89
query34	17.16	4.42	4.45
query35	4.52	4.58	4.48
query36	0.65	0.49	0.48
query37	0.18	0.15	0.15
query38	0.15	0.15	0.14
query39	0.04	0.04	0.04
query40	0.18	0.14	0.15
query41	0.10	0.04	0.05
query42	0.06	0.04	0.05
query43	0.05	0.05	0.04
Total cold run time: 110.1 s
Total hot run time: 30.56 s

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.47% (9007/24700)
Line Coverage: 28.01% (73889/263765)
Region Coverage: 27.49% (38378/139604)
Branch Coverage: 24.19% (19562/80868)
Coverage Report: http://coverage.selectdb-in.cc/coverage/378028095c275e9a1fe62a0a81ae409048800e9e_378028095c275e9a1fe62a0a81ae409048800e9e/report/index.html

@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot
Copy link
Copy Markdown

TPC-H: Total hot run time: 40281 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 378028095c275e9a1fe62a0a81ae409048800e9e, data reload: false

------ Round 1 ----------------------------------
q1	17651	4405	4320	4320
q2	2023	192	203	192
q3	10443	1152	1077	1077
q4	10189	792	839	792
q5	7507	2674	2687	2674
q6	232	137	139	137
q7	978	617	607	607
q8	9231	2090	2077	2077
q9	8946	6510	6497	6497
q10	8975	3730	3782	3730
q11	444	255	241	241
q12	443	237	230	230
q13	19008	2984	2987	2984
q14	282	221	226	221
q15	513	487	484	484
q16	537	388	379	379
q17	984	722	686	686
q18	8073	7606	7469	7469
q19	7755	1555	1540	1540
q20	669	328	331	328
q21	4960	3277	3875	3277
q22	400	339	346	339
Total cold run time: 120243 ms
Total hot run time: 40281 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4470	4264	4280	4264
q2	374	285	264	264
q3	3293	2943	2955	2943
q4	2040	1823	1715	1715
q5	5523	5519	5586	5519
q6	232	143	141	141
q7	2270	1891	1888	1888
q8	3341	3444	3460	3444
q9	8704	8864	8700	8700
q10	4039	3790	3847	3790
q11	609	526	513	513
q12	826	683	629	629
q13	15940	3161	3193	3161
q14	314	273	277	273
q15	531	486	493	486
q16	490	414	430	414
q17	1817	1500	1480	1480
q18	8299	8020	7950	7950
q19	1850	1654	1670	1654
q20	3179	1881	1878	1878
q21	8498	4835	4982	4835
q22	652	539	581	539
Total cold run time: 77291 ms
Total hot run time: 56480 ms

@doris-robot
Copy link
Copy Markdown

TPC-DS: Total hot run time: 175252 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 378028095c275e9a1fe62a0a81ae409048800e9e, data reload: false

query1	905	397	371	371
query2	6371	2472	2235	2235
query3	6631	211	220	211
query4	19133	17312	17299	17299
query5	3713	488	487	487
query6	244	174	168	168
query7	4588	307	301	301
query8	351	308	293	293
query9	8608	2418	2401	2401
query10	573	309	289	289
query11	10641	9986	9941	9941
query12	115	88	87	87
query13	1628	384	363	363
query14	9209	7719	7669	7669
query15	244	192	193	192
query16	7243	260	259	259
query17	1507	546	515	515
query18	1886	278	271	271
query19	208	151	158	151
query20	91	83	87	83
query21	215	134	129	129
query22	4212	4039	3933	3933
query23	33791	33759	33888	33759
query24	11336	2938	2903	2903
query25	591	389	408	389
query26	717	155	156	155
query27	2344	333	328	328
query28	6056	2187	2157	2157
query29	874	651	641	641
query30	254	156	158	156
query31	953	761	767	761
query32	92	53	56	53
query33	708	298	285	285
query34	959	509	477	477
query35	771	665	646	646
query36	1125	1005	984	984
query37	142	78	73	73
query38	2976	2860	2850	2850
query39	907	843	813	813
query40	220	138	136	136
query41	57	53	51	51
query42	123	97	103	97
query43	579	572	528	528
query44	1089	733	749	733
query45	193	163	172	163
query46	1064	749	723	723
query47	1862	1761	1766	1761
query48	366	306	292	292
query49	844	409	406	406
query50	771	400	392	392
query51	6951	6797	6750	6750
query52	106	104	98	98
query53	372	300	292	292
query54	875	443	473	443
query55	74	76	73	73
query56	280	275	258	258
query57	1128	1036	1035	1035
query58	255	267	255	255
query59	3446	3197	3258	3197
query60	304	271	275	271
query61	105	90	89	89
query62	608	435	451	435
query63	324	292	287	287
query64	8509	2238	1762	1762
query65	3167	3105	3114	3105
query66	796	337	343	337
query67	15544	14963	15014	14963
query68	4538	546	564	546
query69	561	390	378	378
query70	1159	1155	1166	1155
query71	407	295	288	288
query72	7000	5511	5599	5511
query73	757	325	329	325
query74	5835	5547	5503	5503
query75	3392	2673	2671	2671
query76	2163	1052	992	992
query77	456	309	313	309
query78	10450	9946	9918	9918
query79	2137	523	519	519
query80	2972	496	472	472
query81	564	222	229	222
query82	818	113	105	105
query83	329	170	172	170
query84	266	88	95	88
query85	2018	289	271	271
query86	494	296	335	296
query87	3288	3100	3140	3100
query88	3931	2354	2346	2346
query89	481	402	397	397
query90	1714	193	190	190
query91	129	101	99	99
query92	66	52	53	52
query93	2564	507	497	497
query94	1112	193	220	193
query95	407	316	320	316
query96	600	268	265	265
query97	3183	3045	3025	3025
query98	217	206	193	193
query99	1199	830	843	830
Total cold run time: 268131 ms
Total hot run time: 175252 ms

@doris-robot
Copy link
Copy Markdown

ClickBench: Total hot run time: 30.8 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 378028095c275e9a1fe62a0a81ae409048800e9e, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.03	0.04
query3	0.22	0.05	0.05
query4	1.66	0.08	0.10
query5	0.51	0.50	0.50
query6	1.14	0.72	0.72
query7	0.02	0.01	0.02
query8	0.05	0.05	0.05
query9	0.55	0.51	0.48
query10	0.54	0.54	0.55
query11	0.15	0.11	0.12
query12	0.15	0.11	0.13
query13	0.61	0.59	0.60
query14	0.76	0.79	0.78
query15	0.85	0.82	0.83
query16	0.40	0.36	0.36
query17	0.94	0.98	0.97
query18	0.23	0.26	0.25
query19	1.78	1.70	1.68
query20	0.01	0.02	0.01
query21	15.41	0.67	0.66
query22	4.60	6.75	2.08
query23	18.31	1.44	1.29
query24	2.15	0.22	0.24
query25	0.15	0.08	0.09
query26	0.27	0.17	0.17
query27	0.07	0.08	0.07
query28	13.18	1.02	1.00
query29	12.60	3.30	3.28
query30	0.25	0.06	0.06
query31	2.87	0.38	0.38
query32	3.28	0.47	0.47
query33	2.88	2.90	2.89
query34	17.19	4.44	4.41
query35	4.51	4.48	4.49
query36	0.65	0.46	0.48
query37	0.20	0.16	0.16
query38	0.15	0.15	0.15
query39	0.05	0.04	0.04
query40	0.18	0.14	0.14
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.84 s
Total hot run time: 30.8 s

@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

TPC-H: Total hot run time: 39718 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 85a7c18ec96a8012094c4ea93ce1959f07c7684d, data reload: false

------ Round 1 ----------------------------------
q1	17598	4523	4275	4275
q2	2011	197	194	194
q3	10466	1118	1106	1106
q4	10206	779	814	779
q5	7492	2728	2675	2675
q6	218	131	132	131
q7	954	596	628	596
q8	9220	2061	2067	2061
q9	8737	6543	6488	6488
q10	8941	3715	3729	3715
q11	444	246	238	238
q12	499	231	229	229
q13	18858	2986	2989	2986
q14	266	222	221	221
q15	508	482	476	476
q16	488	374	377	374
q17	966	580	707	580
q18	8082	7418	7534	7418
q19	8092	1429	1415	1415
q20	644	316	344	316
q21	5048	3112	3206	3112
q22	405	339	333	333
Total cold run time: 120143 ms
Total hot run time: 39718 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4416	4250	4219	4219
q2	362	271	277	271
q3	3075	2881	2947	2881
q4	1984	1780	1753	1753
q5	5503	5467	5450	5450
q6	221	125	126	125
q7	2199	1871	1808	1808
q8	3328	3422	3453	3422
q9	8711	8759	8744	8744
q10	4138	3810	3796	3796
q11	580	501	506	501
q12	829	627	644	627
q13	17169	3130	3152	3130
q14	301	282	271	271
q15	539	486	475	475
q16	496	432	433	432
q17	1817	1532	1497	1497
q18	8115	8006	7749	7749
q19	1821	1680	1730	1680
q20	2100	1876	1887	1876
q21	5096	5100	4696	4696
q22	600	565	573	565
Total cold run time: 73400 ms
Total hot run time: 55968 ms

@doris-robot
Copy link
Copy Markdown

TPC-DS: Total hot run time: 173986 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 85a7c18ec96a8012094c4ea93ce1959f07c7684d, data reload: false

query1	912	389	376	376
query2	6442	2386	2266	2266
query3	6619	212	227	212
query4	18768	17369	17331	17331
query5	3608	467	474	467
query6	236	166	159	159
query7	4581	302	299	299
query8	320	285	280	280
query9	8651	2469	2430	2430
query10	551	303	271	271
query11	11411	9959	10041	9959
query12	110	87	76	76
query13	1628	375	370	370
query14	10235	7726	6982	6982
query15	262	186	186	186
query16	7959	281	273	273
query17	1875	535	534	534
query18	2046	293	284	284
query19	200	162	165	162
query20	91	84	82	82
query21	205	133	128	128
query22	4290	4072	4022	4022
query23	33771	33623	33456	33456
query24	10717	2894	2793	2793
query25	586	378	386	378
query26	732	160	156	156
query27	2296	323	320	320
query28	5948	2172	2170	2170
query29	888	625	629	625
query30	248	154	157	154
query31	1009	772	745	745
query32	96	51	54	51
query33	656	301	295	295
query34	891	477	493	477
query35	753	624	652	624
query36	1140	958	974	958
query37	153	76	79	76
query38	2964	2847	2857	2847
query39	913	843	838	838
query40	249	133	127	127
query41	57	54	48	48
query42	109	105	108	105
query43	627	570	561	561
query44	1112	757	739	739
query45	191	160	156	156
query46	1070	747	708	708
query47	1844	1748	1795	1748
query48	385	295	298	295
query49	826	417	417	417
query50	788	394	422	394
query51	6940	6716	6641	6641
query52	105	99	94	94
query53	357	306	297	297
query54	885	441	449	441
query55	77	74	73	73
query56	284	262	263	262
query57	1137	1031	1063	1031
query58	254	238	248	238
query59	3604	3343	3307	3307
query60	286	295	271	271
query61	94	87	89	87
query62	628	443	446	443
query63	327	292	291	291
query64	8478	2251	1765	1765
query65	3157	3122	3124	3122
query66	742	360	322	322
query67	15508	15150	15009	15009
query68	4487	553	546	546
query69	538	425	383	383
query70	1154	1148	1129	1129
query71	382	278	279	278
query72	7207	5881	5480	5480
query73	758	328	330	328
query74	5885	5519	5557	5519
query75	3321	2696	2651	2651
query76	2215	936	920	920
query77	441	301	308	301
query78	10267	9952	9643	9643
query79	2661	534	533	533
query80	1155	481	480	480
query81	589	218	221	218
query82	745	115	111	111
query83	229	174	179	174
query84	239	88	90	88
query85	1573	296	286	286
query86	479	331	303	303
query87	3324	3107	3103	3103
query88	3855	2377	2352	2352
query89	477	393	381	381
query90	1676	187	188	187
query91	131	100	102	100
query92	65	54	53	53
query93	2005	514	509	509
query94	1062	190	191	190
query95	405	310	317	310
query96	589	267	266	266
query97	3175	3011	3037	3011
query98	208	204	196	196
query99	1174	853	854	853
Total cold run time: 267353 ms
Total hot run time: 173986 ms

@doris-robot
Copy link
Copy Markdown

ClickBench: Total hot run time: 30.68 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 85a7c18ec96a8012094c4ea93ce1959f07c7684d, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.06	0.06
query4	1.67	0.06	0.07
query5	0.50	0.49	0.50
query6	1.13	0.74	0.72
query7	0.02	0.01	0.01
query8	0.05	0.03	0.04
query9	0.53	0.49	0.50
query10	0.54	0.54	0.54
query11	0.15	0.12	0.11
query12	0.15	0.12	0.13
query13	0.59	0.58	0.59
query14	0.76	0.78	0.79
query15	0.83	0.81	0.80
query16	0.37	0.35	0.36
query17	0.98	1.02	0.97
query18	0.23	0.23	0.27
query19	1.76	1.71	1.66
query20	0.01	0.01	0.01
query21	15.40	0.66	0.66
query22	3.99	7.31	1.94
query23	18.27	1.39	1.29
query24	2.12	0.21	0.22
query25	0.15	0.08	0.08
query26	0.26	0.17	0.18
query27	0.08	0.08	0.07
query28	13.29	1.04	1.00
query29	12.65	3.29	3.28
query30	0.26	0.06	0.06
query31	2.86	0.38	0.38
query32	3.32	0.47	0.47
query33	2.88	2.95	3.00
query34	17.02	4.49	4.49
query35	4.53	4.47	4.49
query36	0.64	0.47	0.48
query37	0.19	0.16	0.16
query38	0.16	0.15	0.15
query39	0.04	0.04	0.03
query40	0.16	0.14	0.14
query41	0.09	0.06	0.05
query42	0.06	0.05	0.04
query43	0.05	0.04	0.05
Total cold run time: 109.08 s
Total hot run time: 30.68 s

@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

TPC-H: Total hot run time: 40178 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3eed9d64c96242506d2071710d499bfbfeb3467c, data reload: false

------ Round 1 ----------------------------------
q1	17787	4662	4471	4471
q2	2262	195	188	188
q3	11494	1109	1160	1109
q4	10663	764	807	764
q5	7559	2751	2694	2694
q6	221	136	138	136
q7	965	617	617	617
q8	9291	2116	2110	2110
q9	9133	6547	6529	6529
q10	8935	3719	3679	3679
q11	455	246	240	240
q12	461	224	221	221
q13	18789	2967	2976	2967
q14	262	231	221	221
q15	508	480	482	480
q16	494	383	380	380
q17	970	640	717	640
q18	8056	7567	7479	7479
q19	3591	1454	1493	1454
q20	656	320	326	320
q21	4984	3145	3921	3145
q22	385	334	339	334
Total cold run time: 117921 ms
Total hot run time: 40178 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4357	4208	4259	4208
q2	369	274	262	262
q3	2973	2727	2705	2705
q4	1902	1642	1589	1589
q5	5302	5256	5289	5256
q6	215	127	124	124
q7	2146	1717	1732	1717
q8	3170	3340	3318	3318
q9	8356	8371	8332	8332
q10	3872	3651	3654	3651
q11	577	491	489	489
q12	793	590	611	590
q13	16423	3008	2968	2968
q14	285	264	277	264
q15	518	477	491	477
q16	481	402	406	402
q17	1749	1473	1501	1473
q18	7606	7531	7408	7408
q19	1707	1618	1673	1618
q20	2027	1763	1770	1763
q21	4849	4668	4786	4668
q22	619	566	530	530
Total cold run time: 70296 ms
Total hot run time: 53812 ms

@doris-robot
Copy link
Copy Markdown

TPC-DS: Total hot run time: 173132 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3eed9d64c96242506d2071710d499bfbfeb3467c, data reload: false

query1	937	376	374	374
query2	6449	2400	2324	2324
query3	6637	202	204	202
query4	19068	17148	17168	17148
query5	4156	457	460	457
query6	242	157	168	157
query7	4592	294	298	294
query8	346	306	294	294
query9	8490	2405	2378	2378
query10	610	312	263	263
query11	10548	9949	10023	9949
query12	134	83	86	83
query13	1792	367	371	367
query14	10167	7687	7652	7652
query15	293	195	194	194
query16	8171	282	275	275
query17	1873	557	538	538
query18	2114	274	276	274
query19	198	162	162	162
query20	91	85	84	84
query21	211	129	130	129
query22	4375	4100	4005	4005
query23	33830	33055	33141	33055
query24	10992	2868	2917	2868
query25	635	377	389	377
query26	1373	157	154	154
query27	2909	314	322	314
query28	7302	2059	2057	2057
query29	892	640	626	626
query30	274	150	154	150
query31	974	759	746	746
query32	95	55	53	53
query33	792	309	292	292
query34	925	480	458	458
query35	774	634	621	621
query36	1126	946	956	946
query37	153	70	71	70
query38	2924	2802	2726	2726
query39	836	783	796	783
query40	215	130	133	130
query41	53	55	55	55
query42	115	101	99	99
query43	569	538	563	538
query44	1184	749	738	738
query45	199	160	171	160
query46	1078	727	719	719
query47	1871	1754	1753	1753
query48	365	289	295	289
query49	1111	440	409	409
query50	780	382	394	382
query51	6873	6727	6784	6727
query52	106	100	91	91
query53	361	291	301	291
query54	878	460	437	437
query55	76	77	79	77
query56	299	274	277	274
query57	1128	1047	1059	1047
query58	265	245	249	245
query59	3519	3271	3167	3167
query60	323	298	292	292
query61	109	110	107	107
query62	632	449	468	449
query63	322	404	290	290
query64	8952	2193	1732	1732
query65	3155	3096	3110	3096
query66	1329	342	341	341
query67	15606	14962	15019	14962
query68	7281	549	540	540
query69	680	471	398	398
query70	1213	1191	1043	1043
query71	529	265	279	265
query72	8752	5208	5432	5208
query73	796	331	323	323
query74	5923	5530	5420	5420
query75	5032	2650	2654	2650
query76	4797	963	922	922
query77	780	301	292	292
query78	10656	9770	9793	9770
query79	7399	514	516	514
query80	1000	465	468	465
query81	547	216	218	216
query82	809	113	100	100
query83	416	171	166	166
query84	265	87	83	83
query85	1439	269	267	267
query86	452	291	330	291
query87	3255	3072	3075	3072
query88	5102	2347	2356	2347
query89	497	399	379	379
query90	1919	185	187	185
query91	127	96	100	96
query92	60	47	50	47
query93	6253	520	502	502
query94	1232	186	188	186
query95	408	313	321	313
query96	602	266	262	262
query97	3155	2998	2990	2990
query98	226	202	194	194
query99	1248	853	830	830
Total cold run time: 292623 ms
Total hot run time: 173132 ms

@doris-robot
Copy link
Copy Markdown

ClickBench: Total hot run time: 30.45 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3eed9d64c96242506d2071710d499bfbfeb3467c, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.08	0.08
query5	0.48	0.48	0.49
query6	1.13	0.73	0.72
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.54	0.48	0.50
query10	0.55	0.54	0.55
query11	0.15	0.11	0.11
query12	0.14	0.12	0.12
query13	0.59	0.59	0.58
query14	0.76	0.80	0.80
query15	0.83	0.82	0.83
query16	0.36	0.36	0.36
query17	0.94	1.05	1.03
query18	0.21	0.27	0.22
query19	1.92	1.70	1.73
query20	0.01	0.01	0.01
query21	15.44	0.65	0.66
query22	4.68	6.90	1.96
query23	18.31	1.34	1.16
query24	2.22	0.22	0.21
query25	0.16	0.08	0.08
query26	0.26	0.17	0.18
query27	0.08	0.09	0.08
query28	13.19	1.02	1.00
query29	12.63	3.29	3.32
query30	0.25	0.06	0.05
query31	2.86	0.40	0.37
query32	3.29	0.47	0.47
query33	2.83	2.97	2.88
query34	16.87	4.40	4.38
query35	4.47	4.45	4.41
query36	0.65	0.46	0.47
query37	0.19	0.16	0.16
query38	0.16	0.14	0.15
query39	0.04	0.03	0.03
query40	0.18	0.14	0.14
query41	0.09	0.05	0.06
query42	0.07	0.05	0.06
query43	0.04	0.04	0.04
Total cold run time: 109.65 s
Total hot run time: 30.45 s

@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor Author

run external

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 27, 2024
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

Copy link
Copy Markdown
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor Author

revert related: #36979

@BiteTheDDDDt BiteTheDDDDt merged commit 127987f into apache:master Jul 1, 2024
dataroaring pushed a commit that referenced this pull request Jul 2, 2024
Arena should not allocate memory in this constructor.

After this pr merged, we shuold revert
#36299
@zhiqiang-hhhh zhiqiang-hhhh deleted the opt-arena branch May 21, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants