[fix](schema change) reduce memory usage of create a good deal of shadow tablets in schema change process#36285
Merged
dataroaring merged 4 commits intoapache:masterfrom Jun 15, 2024
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40194 ms |
TPC-DS: Total hot run time: 173595 ms |
ClickBench: Total hot run time: 30.88 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39822 ms |
TPC-DS: Total hot run time: 171949 ms |
ClickBench: Total hot run time: 30.11 s |
Contributor
Author
|
run p0 |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40324 ms |
TPC-DS: Total hot run time: 172218 ms |
ClickBench: Total hot run time: 30.83 s |
luwei16
approved these changes
Jun 15, 2024
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
PR approved by at least one committer and no changes requested. |
gavinchou
reviewed
Jun 15, 2024
| try { | ||
| BinlogConfig binlogConfig = new BinlogConfig(tbl.getBinlogConfig()); | ||
| Preconditions.checkState(tbl.getState() == OlapTableState.ROLLUP); | ||
| Map<Object, Object> objectPool = new HashMap<Object, Object>(); |
Contributor
There was a problem hiding this comment.
It's better to use a concurrent map.
dataroaring
pushed a commit
that referenced
this pull request
Jun 21, 2024
…dow tablets in schema change process (#36285) When doing schema change, it will create many shadow tablets. And many TCreateTabletReq will be new. So we can use object pool to reduct they memory usage.
This was referenced Jun 24, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jun 25, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jun 25, 2024
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing schema change, it will create many shadow tablets. And many TCreateTabletReq will be new. So we can use object pool to reduct they memory usage.