[bugfix](paimon)paimon's field length judgment error#35981
Merged
morningman merged 1 commit intoapache:masterfrom Jun 13, 2024
Merged
[bugfix](paimon)paimon's field length judgment error#35981morningman merged 1 commit intoapache:masterfrom
morningman merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40888 ms |
TPC-DS: Total hot run time: 171076 ms |
ClickBench: Total hot run time: 30.47 s |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
zddr
approved these changes
Jun 7, 2024
morningman
pushed a commit
that referenced
this pull request
Jun 7, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jun 17, 2024
## Proposed changes Introduced from #35309 `fields.length` indicates the fields we want to read. If a table has 10 fields, but we only select a few fields, then the length of `fields.length` will definitely be less than 10. So the judgment condition here should be greater than.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Introduced from #35309
fields.lengthindicates the fields we want to read. If a table has 10 fields, but we only select a few fields, then the length offields.lengthwill definitely be less than 10.So the judgment condition here should be greater than.