-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[improvement](mtmv) Materialized view partition track supports date_trunc and optimize the fail reason #35562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
af3a6d0
[improvement](mtmv) Add merge data trunc expression rule
seawinde 3aebff6
support date_trunc
seawinde 8d27b2a
[improvement](mtmv) Materialized view partition track supports date_t…
seawinde 22c60f3
optimize comment
seawinde 51a9145
optimize fail reason
seawinde 46bb24e
optimize code usage
seawinde dfb0910
fix comment
seawinde ca32ba0
fix comment
seawinde a0300ae
fix comment
seawinde 8e642e8
fix partition by direct column
seawinde c3e1009
fix partition comment
seawinde 1e0a21e
fix regressiont test
seawinde 03158de
agg regression test
seawinde dd18de1
fix regression test column name
seawinde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
221 changes: 193 additions & 28 deletions
221
...re/src/main/java/org/apache/doris/nereids/rules/exploration/mv/MaterializedViewUtils.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78 changes: 78 additions & 0 deletions
78
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/MergeDateTrunc.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.nereids.rules.expression.rules; | ||
|
|
||
| import org.apache.doris.nereids.rules.expression.ExpressionPatternMatcher; | ||
| import org.apache.doris.nereids.rules.expression.ExpressionPatternRuleFactory; | ||
| import org.apache.doris.nereids.trees.expressions.Expression; | ||
| import org.apache.doris.nereids.trees.expressions.functions.scalar.DateTrunc; | ||
| import org.apache.doris.nereids.trees.expressions.literal.Interval.TimeUnit; | ||
| import org.apache.doris.nereids.trees.expressions.literal.Literal; | ||
| import org.apache.doris.nereids.trees.expressions.literal.VarcharLiteral; | ||
|
|
||
| import com.google.common.collect.ImmutableList; | ||
| import com.google.common.collect.ImmutableSet; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Optional; | ||
|
|
||
| /** | ||
| * Rewrite rule to convert | ||
| * For example: | ||
| * date_trunc(date_trunc(data_slot, 'hour'), 'day') -> date_trunc(data_slot, 'day') | ||
| */ | ||
| public class MergeDateTrunc implements ExpressionPatternRuleFactory { | ||
|
|
||
| public static MergeDateTrunc INSTANCE = new MergeDateTrunc(); | ||
| public static ImmutableSet<TimeUnit> UN_SUPPORT_TIME_UNIT = ImmutableSet.of(TimeUnit.WEEK, TimeUnit.QUARTER); | ||
|
|
||
| @Override | ||
| public List<ExpressionPatternMatcher<? extends Expression>> buildRules() { | ||
| return ImmutableList.of( | ||
| matchesTopType(DateTrunc.class) | ||
| .when(dateTrunc -> dateTrunc.getArgument(0) instanceof DateTrunc) | ||
| .then(MergeDateTrunc::rewrite) | ||
| ); | ||
| } | ||
|
|
||
| private static Expression rewrite(DateTrunc dateTrunc) { | ||
|
|
||
| Expression parentTimeUnitArgument = dateTrunc.getArgument(1); | ||
| if (!(parentTimeUnitArgument instanceof Literal)) { | ||
| return dateTrunc; | ||
| } | ||
| Optional<TimeUnit> parentTimeUnit = TimeUnit.of(((Literal) parentTimeUnitArgument).getStringValue()); | ||
| DateTrunc childDateTrunc = (DateTrunc) dateTrunc.getArgument(0); | ||
| Expression childTimeUnitArgument = childDateTrunc.getArgument(1); | ||
| if (!(childTimeUnitArgument instanceof Literal)) { | ||
| return dateTrunc; | ||
| } | ||
| Optional<TimeUnit> childTimeUnit = TimeUnit.of(((Literal) childTimeUnitArgument).getStringValue()); | ||
| if (!parentTimeUnit.isPresent() || !childTimeUnit.isPresent()) { | ||
| return dateTrunc; | ||
| } | ||
| if (UN_SUPPORT_TIME_UNIT.contains(parentTimeUnit.get()) | ||
| || UN_SUPPORT_TIME_UNIT.contains(childTimeUnit.get())) { | ||
| return dateTrunc; | ||
| } | ||
| if (parentTimeUnit.get().getLevel() < childTimeUnit.get().getLevel()) { | ||
| return dateTrunc; | ||
| } | ||
| return new DateTrunc(childDateTrunc.getArgument(0), new VarcharLiteral(parentTimeUnit.get().toString())); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.