[opt](inverted index) reduce generation of the rowid_result if not necessary#35357
Merged
xiaokang merged 1 commit intoapache:masterfrom Jun 20, 2024
Merged
[opt](inverted index) reduce generation of the rowid_result if not necessary#35357xiaokang merged 1 commit intoapache:masterfrom
xiaokang merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40111 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 169992 ms |
ClickBench: Total hot run time: 30.61 s |
Contributor
|
PR approved by anyone and no changes requested. |
xiaokang
changed the title
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40752 ms |
TPC-DS: Total hot run time: 170550 ms |
ClickBench: Total hot run time: 30.39 s |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 40146 ms |
TPC-DS: Total hot run time: 169801 ms |
ClickBench: Total hot run time: 30.58 s |
xiaokang
changed the title
xiaokang
reviewed
May 29, 2024
| } | ||
| } | ||
| _col_preds_except_leafnode_of_andnode.clear(); | ||
| for (auto& iter : _rowid_result_for_index) { |
Contributor
There was a problem hiding this comment.
add comment to explain its effect and related code
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 40117 ms |
TPC-DS: Total hot run time: 173278 ms |
ClickBench: Total hot run time: 30.54 s |
zzzxl1993
force-pushed
the
compound_opt_2
branch
from
93ec42b to
05df443
Compare
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 40852 ms |
TPC-DS: Total hot run time: 171886 ms |
ClickBench: Total hot run time: 30.95 s |
Contributor
Author
|
run p0 |
qidaye
approved these changes
Jun 20, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Jun 21, 2024
…cessary (#35357) in the compound process, if all indexes are fully matched, the rowid_result will no longer be generated.
xiaokang
pushed a commit
that referenced
this pull request
Jul 6, 2024
xiaokang
pushed a commit
that referenced
this pull request
Jul 7, 2024
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rocess
Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...