[fix](Nereids) AnalyzeTblStmt should fail when disabling fallback_to_original_planner#34532
[fix](Nereids) AnalyzeTblStmt should fail when disabling fallback_to_original_planner#34532zhangbutao wants to merge 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
@morrySnow Could you help to check this fix? Thx. |
| || s instanceof CreateTableAsSelectStmt | ||
| || s instanceof CreateTableStmt)) { | ||
| || s instanceof CreateTableStmt | ||
| || s instanceof AnalyzeTblStmt)) { |
There was a problem hiding this comment.
analyze table do not impl in Nereids, so should not failed even if disabling fallback_to_original_planner
There was a problem hiding this comment.
Ok. It just makes me confused that analyze table can be sucessful but actually it not be Implemented in Nereids.
set enable_nereids_planner=true;
set enable_fallback_to_original_planner=false;
There was a problem hiding this comment.
BTW, Should we impl analyze table in Neredis side in the future?
There was a problem hiding this comment.
too many statement has not been impl in Nereids.
All these statements will fall back to Legacy planner automaticly even if disable enable_fallback_to_original_planner
Should we impl analyze table in Neredis side in the future
Yes, We should impl ALL statement in Nereids in feature.
Feel free to impl them in Nereids if you're willing.😁
There was a problem hiding this comment.
Sure, i will try to impl partial statements in Nereids if i have any bandwidth. 😃
Thanks.
3 participants
Proposed changes
#32882 disable fallback_to_original_planner by default. I think we have not Implemented
AnalyzeTblStmtsyntax in Nereids. Before we implement it in Nereids, We need to throw ex when turning offfallback_to_original_planner.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...