[fix](nereids)move ReplaceVariableByLiteral rule to analyze phase#33997
Merged
starocean999 merged 2 commits intoapache:masterfrom Apr 26, 2024
Merged
[fix](nereids)move ReplaceVariableByLiteral rule to analyze phase#33997starocean999 merged 2 commits intoapache:masterfrom
starocean999 merged 2 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
morrySnow
reviewed
Apr 24, 2024
| new NormalizeRepeat() | ||
| ), | ||
| bottomUp(new AdjustAggregateNullableForEmptySet()), | ||
| topDown(new VariableToLiteral()), |
Contributor
There was a problem hiding this comment.
add comment to explain why must replace here
starocean999
force-pushed
the
nereids_1019
branch
from
0301050 to
ecc9f8e
Compare
Contributor
Author
|
run buildall |
morrySnow
approved these changes
Apr 25, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
englefly
approved these changes
Apr 26, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 26, 2024
dataroaring
pushed a commit
that referenced
this pull request
Apr 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
consider sql with user defined var @t_zone
@t_zone must be replaced as 'GMT' before EliminateGroupByConstant and NormalizeAggregate rule. So this pr move ReplaceVariableByLiteral rule from rewrite phase to analyze phase and put it before the two rules to make it work.
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...