[fix](row-count-cache) use cached row count for show#33911
Merged
xiaokang merged 1 commit intoapache:masterfrom Apr 20, 2024
Merged
[fix](row-count-cache) use cached row count for show#33911xiaokang merged 1 commit intoapache:masterfrom
xiaokang merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39001 ms |
TPC-DS: Total hot run time: 184073 ms |
ClickBench: Total hot run time: 30.27 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
yiguolei
approved these changes
Apr 20, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Followup #33449
Some operation, like
show tables statusmay traverse all tables and call table's getRowCount() method.This method may trigger the row count cache refresh async, and may take all executor thread and block other
query requests.
This PR change the logic, for some
showrequest likeshow table status, use a new methodgetCachedRowCount().This method will get row count from cache if present, and will not trigger cache refresh if cache miss.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...