[Fix](nereids) fix rule merge_aggregate when has project#33892
Merged
starocean999 merged 4 commits intoapache:masterfrom Apr 26, 2024
Merged
[Fix](nereids) fix rule merge_aggregate when has project#33892starocean999 merged 4 commits intoapache:masterfrom
starocean999 merged 4 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38418 ms |
TPC-DS: Total hot run time: 183979 ms |
ClickBench: Total hot run time: 30.23 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38192 ms |
TPC-DS: Total hot run time: 185253 ms |
ClickBench: Total hot run time: 31.19 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39290 ms |
TPC-DS: Total hot run time: 184504 ms |
ClickBench: Total hot run time: 30.67 s |
feiniaofeiafei
force-pushed
the
merge_agg_bug
branch
from
6bb4604 to
f5ea21e
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38296 ms |
TPC-DS: Total hot run time: 185222 ms |
ClickBench: Total hot run time: 29.96 s |
feiniaofeiafei
force-pushed
the
merge_agg_bug
branch
from
f5ea21e to
f95e424
Compare
Contributor
Author
|
run buildall |
morrySnow
reviewed
Apr 24, 2024
| topDown(new EliminateGroupBy(), | ||
| new MergeAggregate()) | ||
| new MergeAggregate(), | ||
| new AdjustAggregateNullableForEmptySet()) |
Contributor
There was a problem hiding this comment.
add comment here to explain why need execute AdjustAggregateNullableForEmptySet after MergeAggregate
Contributor
Author
|
run buildall |
Contributor
Author
|
run p0 |
morrySnow
approved these changes
Apr 25, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
starocean999
approved these changes
Apr 26, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 26, 2024
dataroaring
pushed a commit
that referenced
this pull request
Apr 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fix 2 problem of merge_aggregate:
1.The map innerAggExprIdToAggFunc key is the inner agg output agg func exprid, value is the Agg func. When a LogicalProject is between 2 agg, the outeragg func child refer to the project output, I forget to do the rewrite to make the outeragg func child refer to the inneragg output. This can lead to an incorrect judgment when determining whether the outer agg func child exists in the inner agg func outputs. This pr fix this bug.
2.When merging 2 sum/min/max, the outer agg group by key is empty, and the inner agg group by key is not empty, the nullable attribute need to be adjusted. Because the sum without group by key is always nullable, the sum with group by key nullable attribute determined by the sum child nullable attribute. This pr fix this bug.