[Fix](Variant) VariantRootColumnIterator::read_by_rowids with wrong null map size#33734
Merged
eldenmoon merged 1 commit intoapache:masterfrom Apr 18, 2024
Merged
[Fix](Variant) VariantRootColumnIterator::read_by_rowids with wrong null map size#33734eldenmoon merged 1 commit intoapache:masterfrom
eldenmoon merged 1 commit intoapache:masterfrom
Conversation
…ull map size insert_range_from should start from `size` with `count` elements for null map
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38533 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 184693 ms |
ClickBench: Total hot run time: 30.25 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
xiaokang
changed the title
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
qidaye
approved these changes
Apr 18, 2024
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Apr 18, 2024
…ull map size (apache#33734) insert_range_from should start from `size` with `count` elements for null map
yiguolei
pushed a commit
that referenced
this pull request
Apr 18, 2024
…ull map size (#33734) insert_range_from should start from `size` with `count` elements for null map
yiguolei
pushed a commit
that referenced
this pull request
Apr 18, 2024
* [Fix](Variant Type) forbit distribution info contains variant columns (#33707) * [Fix](Variant) VariantRootColumnIterator::read_by_rowids with wrong null map size (#33734) insert_range_from should start from `size` with `count` elements for null map * [Fix](Variant) check column index validation for extracted columns (#33766)
dataroaring
pushed a commit
that referenced
this pull request
Apr 24, 2024
…ull map size (#33734) insert_range_from should start from `size` with `count` elements for null map
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ull map size
insert_range_from should start from
sizewithcountelements for null mapProposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...