[fix](inverted index) normal process query for null condition when in…#33663
Merged
qidaye merged 1 commit intoapache:masterfrom Apr 17, 2024
Merged
[fix](inverted index) normal process query for null condition when in…#33663qidaye merged 1 commit intoapache:masterfrom
qidaye merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return Status::OK(); | ||
| }; | ||
|
|
||
| Status InvertedIndexReader::check_file_exist(const std::string& index_file_key) { |
Contributor
There was a problem hiding this comment.
warning: method 'check_file_exist' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status InvertedIndexReader::check_file_exist(const std::string& index_file_key) { | |
| static Status InvertedIndexReader::check_file_exist(const std::string& index_file_key) { |
Contributor
Author
|
run buildall |
| class InvertedIndexColumnWriterEmptyImpl final : public InvertedIndexColumnWriter { | ||
| public: | ||
| Status init() override { return Status::OK(); } | ||
| Status add_values(const std::string name, const void* values, |
Contributor
There was a problem hiding this comment.
warning: method 'add_values' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status add_values(const std::string name, const void* values, | |
| static Status add_values(const std::string name, const void* values, |
Additional context
be/src/util/debug_points.h:39: expanded from macro 'DBUG_EXECUTE_IF'
code; \
^
Contributor
|
PR approved by anyone and no changes requested. |
qidaye
previously approved these changes
Apr 16, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
TPC-H: Total hot run time: 38609 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 183123 ms |
ClickBench: Total hot run time: 29.98 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run p0 |
github-actions
bot
removed
the
approved
Contributor
Author
|
run p0 |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38758 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 185029 ms |
ClickBench: Total hot run time: 30.5 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run p0 |
qidaye
approved these changes
Apr 17, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
yiguolei
pushed a commit
that referenced
this pull request
Apr 17, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 17, 2024
xiaokang
pushed a commit
that referenced
this pull request
Apr 18, 2024
dataroaring
pushed a commit
that referenced
this pull request
Apr 24, 2024
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dex is missing
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...