[Feat](nereids) add transform rule SimplifyWindowExpression#33647
Merged
morrySnow merged 10 commits intoapache:masterfrom Apr 24, 2024
Merged
[Feat](nereids) add transform rule SimplifyWindowExpression#33647morrySnow merged 10 commits intoapache:masterfrom
morrySnow merged 10 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38228 ms |
TPC-DS: Total hot run time: 184160 ms |
ClickBench: Total hot run time: 30.26 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38584 ms |
TPC-DS: Total hot run time: 183515 ms |
ClickBench: Total hot run time: 30.08 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38228 ms |
TPC-DS: Total hot run time: 182733 ms |
ClickBench: Total hot run time: 30.57 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run external |
Contributor
Author
|
run external regression |
Contributor
Author
|
run external |
Contributor
Author
|
run external regression |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38581 ms |
Contributor
Author
|
run p0 |
1 similar comment
Contributor
Author
|
run p0 |
morrySnow
reviewed
Apr 17, 2024
Comment on lines
+115
to
+129
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
| * select max(c1) over(partition by pk) from t1; | ||
| * -> select c1 from t1; | ||
| * */ | ||
| public class SimplifyWindowExpression extends OneRewriteRuleFactory { |
Contributor
There was a problem hiding this comment.
add annotation @DependsRules for denpends on normalize window
| Alias alias = (Alias) expr; | ||
| WindowExpression windowExpression = (WindowExpression) alias.child(); | ||
| if (!windowExpression.getOrderKeys().isEmpty()) { | ||
| remainWindowExpression.add(expr); |
Contributor
There was a problem hiding this comment.
if partition key is unique, order key is not use anymore, so why remain them?
Contributor
Author
There was a problem hiding this comment.
LogicalWindow
->
LogicalProject(projections)
+ LogicalWindow(remainWindowExpression)
remainWindowExpressions are the WindowExpressions that don't meet the conditions for optimization, and still need to be evaluated int LogicalWindow.
Contributor
Author
There was a problem hiding this comment.
Tthe restriction has been removed
Comment on lines
+109
to
+110
| return new LogicalProject(projections, window.withExpression(remainWindow, | ||
| window.child(0))); |
Contributor
There was a problem hiding this comment.
do u have case to test this branch? i think this is not right because project should contain remain window node's output
Contributor
Author
There was a problem hiding this comment.
The problem has been modified and regression cases have been added
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38169 ms |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
Contributor
Author
|
run p0 |
starocean999
approved these changes
Apr 19, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
924060929
approved these changes
Apr 19, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 24, 2024
rewrite func(para) over (partition by unique_keys) 1. func() is count(non-null) or rank/dense_rank/row_number -> 1 2. func(para) is min/max/sum/avg/first_value/last_value -> para e.g select max(c1) over(partition by pk) from t1; -> select c1 from t1;
yiguolei
pushed a commit
that referenced
this pull request
Apr 24, 2024
rewrite func(para) over (partition by unique_keys) 1. func() is count(non-null) or rank/dense_rank/row_number -> 1 2. func(para) is min/max/sum/avg/first_value/last_value -> para e.g select max(c1) over(partition by pk) from t1; -> select c1 from t1;
yiguolei
pushed a commit
that referenced
this pull request
Apr 25, 2024
rewrite func(para) over (partition by unique_keys) 1. func() is count(non-null) or rank/dense_rank/row_number -> 1 2. func(para) is min/max/sum/avg/first_value/last_value -> para e.g select max(c1) over(partition by pk) from t1; -> select c1 from t1;
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Jul 9, 2024
…pache#37061) intro by apache#33647 after window expression rewritten by literal. literal's data type should same with original window expression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rewrite func(para) over (partition by unique_keys)
e.g
select max(c1) over(partition by pk) from t1;
-> select c1 from t1;