[opt](inverted index) prevent excessive memory usage caused by too many terms.#33609
Merged
qidaye merged 1 commit intoapache:masterfrom Apr 18, 2024
Merged
[opt](inverted index) prevent excessive memory usage caused by too many terms.#33609qidaye merged 1 commit intoapache:masterfrom
qidaye merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
xiaokang
reviewed
Apr 15, 2024
| return 0; | ||
| }; | ||
| re2::RE2 pattern(terms[0]); | ||
| std::vector<std::string> results; |
Contributor
There was a problem hiding this comment.
The original name terms is more easy to understand.
| std::vector<Term*> _terms; | ||
| std::vector<TermDocs*> _term_docs; | ||
| std::vector<TermIterator> _term_iterators; | ||
| // std::vector<Term*> _terms; |
| // std::vector<TermDocs*> _term_docs; | ||
| // std::vector<TermIterator> _term_iterators; | ||
|
|
||
| std::wstring _field_name; |
Contributor
There was a problem hiding this comment.
It's better to put common fields: _filed_name and _terms in parent class Query.
| for (int i = 0; i < _terms.size(); i++) { | ||
| if (i == 0) { | ||
| func(iter, true); | ||
| func(_terms[i], true); |
Contributor
There was a problem hiding this comment.
use one call func(_terms[i], i == 0) instead of if else
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
zzzxl1993
changed the title
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38352 ms |
TPC-DS: Total hot run time: 185122 ms |
ClickBench: Total hot run time: 30 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
qidaye
approved these changes
Apr 18, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 18, 2024
dataroaring
pushed a commit
that referenced
this pull request
Apr 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...