[bug](regression) fix regression test test-table-version in cloud_p0#33462
Merged
xy720 merged 4 commits intoapache:masterfrom Apr 11, 2024
Merged
[bug](regression) fix regression test test-table-version in cloud_p0#33462xy720 merged 4 commits intoapache:masterfrom
xy720 merged 4 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Member
Author
|
run buildall |
1 similar comment
Member
Author
|
run buildall |
xy720
changed the title
Member
Author
|
run buildall |
1 similar comment
Member
Author
|
run buildall |
xy720
force-pushed
the
fix-test-table-vesion
branch
from
1e5f766 to
b39c183
Compare
Member
Author
|
run buildall |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
Bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
gavinchou
reviewed
Apr 10, 2024
| long versionTime = System.currentTimeMillis(); | ||
| olapTable.updateVisibleVersionAndTime(version, versionTime); | ||
|
|
||
| long version = olapTable.getVisibleVersion(); |
Member
Author
There was a problem hiding this comment.
Users must obtain write lock of OlapTable before calling the dropPartition method.
Member
Author
There was a problem hiding this comment.
I found that the commit transaction holds a commit lock for the table. May be I need to hold a commit lock here?
gavinchou
approved these changes
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Fix regression test test-table-version.
introduce by:#32989
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...