[pipelineX](runtime filter) Fix task timeout caused by runtime filter#33332
Merged
yiguolei merged 8 commits intoapache:masterfrom Apr 8, 2024
Merged
[pipelineX](runtime filter) Fix task timeout caused by runtime filter#33332yiguolei merged 8 commits intoapache:masterfrom
yiguolei merged 8 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Gabriel39
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38698 ms |
yiguolei
reviewed
Apr 7, 2024
yiguolei
reviewed
Apr 7, 2024
yiguolei
reviewed
Apr 7, 2024
yiguolei
reviewed
Apr 7, 2024
yiguolei
reviewed
Apr 7, 2024
yiguolei
reviewed
Apr 7, 2024
yiguolei
reviewed
Apr 7, 2024
yiguolei
reviewed
Apr 7, 2024
Contributor
Author
|
run buildall |
yiguolei
reviewed
Apr 8, 2024
| // In pipelineX, runtime filters will be ready or timeout before open phase. | ||
| if (expected == RuntimeFilterState::NOT_READY) { | ||
| DCHECK(MonotonicMillis() - registration_time_ >= wait_times_ms); | ||
| _rf_state_atomic = RuntimeFilterState::TIME_OUT; |
Contributor
There was a problem hiding this comment.
我们为啥要把not_Ready 状态更改为 TIME_OUT
Contributor
Author
There was a problem hiding this comment.
执行到这里的时候rf状态要么是timeout要么是ready，ready的话状态是已经被更新过的，所以这个地方是timeout。更新状态是因为要在profile显示
TPC-H: Total hot run time: 38804 ms |
|
TeamCity be ut coverage result: |
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Gabriel39
added a commit
to Gabriel39/incubator-doris
that referenced
this pull request
Apr 8, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 8, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...