[feature](local-tvf) support local tvf on shared storage#33050
Merged
morningman merged 2 commits intoapache:masterfrom Apr 1, 2024
Merged
[feature](local-tvf) support local tvf on shared storage#33050morningman merged 2 commits intoapache:masterfrom
morningman merged 2 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
BePPPower
reviewed
Mar 29, 2024
Comment on lines
+86
to
+88
| } else if (backendId != -1 && sharedStorage) { | ||
| throw new AnalysisException("'shared_storage' should be false when 'backend_id' is set."); | ||
| } |
Contributor
There was a problem hiding this comment.
This else-if logic is inconsistent with the pr description？
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38552 ms |
TPC-DS: Total hot run time: 181777 ms |
ClickBench: Total hot run time: 29.82 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
AshinGau
approved these changes
Apr 1, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
Bot
added
the
approved
morningman
added a commit
to morningman/doris
that referenced
this pull request
Apr 7, 2024
Previously, local tvf can only query data on one BE node.
But if the storage is shared(eg, NAS), it can be executed on multi nodes.
This PR mainly changes:
1. Add a new property `"shared_stoage" = "false/true"`
Default is false, if set to true, "backend_id" is optional. If "backend_id" is set,
it still be executed on that BE, if not set, "shared_stoage" must be "true"
and it will be executed on multi nodes.
Doc: apache/doris-website#494
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previously, local tvf can only query data on one BE node.
But if the storage is shared(eg, NAS), it can be executed on multi nodes.
This PR mainly changes:
Add a new property
"shared_stoage" = "false/true"Default is false, if set to true, "backend_id" is optional. If "backend_id" is set,
it still be executed on that BE, if not set, "shared_stoage" must be "true"
and it will be executed on multi nodes.
Doc: apache/doris-website#494
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...