Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@
import org.apache.doris.nereids.trees.plans.commands.CreateTableCommand;
import org.apache.doris.nereids.trees.plans.commands.Forward;
import org.apache.doris.nereids.trees.plans.commands.NotAllowFallback;
import org.apache.doris.nereids.trees.plans.commands.UpdateCommand;
import org.apache.doris.nereids.trees.plans.commands.insert.BatchInsertIntoTableCommand;
import org.apache.doris.nereids.trees.plans.commands.insert.InsertIntoTableCommand;
import org.apache.doris.nereids.trees.plans.commands.insert.InsertOverwriteTableCommand;
Expand Down Expand Up @@ -649,9 +650,9 @@ private void executeByNereids(TUniqueId queryId) throws Exception {
LogicalPlan logicalPlan = ((LogicalPlanAdapter) parsedStmt).getLogicalPlan();
// when we in transaction mode, we only support insert into command and transaction command
if (context.isTxnModel()) {
if (!(logicalPlan instanceof BatchInsertIntoTableCommand
|| logicalPlan instanceof InsertIntoTableCommand)) {
String errMsg = "This is in a transaction, only insert, commit, rollback is acceptable.";
if (!(logicalPlan instanceof BatchInsertIntoTableCommand || logicalPlan instanceof InsertIntoTableCommand
|| logicalPlan instanceof UpdateCommand)) {
String errMsg = "This is in a transaction, only insert, update, commit, rollback is acceptable.";
throw new NereidsException(errMsg, new AnalysisException(errMsg));
}
}
Expand Down
6 changes: 6 additions & 0 deletions regression-test/data/insert_p0/txn_insert.out
Original file line number Diff line number Diff line change
Expand Up @@ -298,3 +298,9 @@
2 3.3 xyz [1] [1, 0]
2 3.3 xyz [1] [1, 0]

-- !select25 --
1 a 101

-- !select26 --
1 a 100

29 changes: 29 additions & 0 deletions regression-test/suites/insert_p0/txn_insert.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -213,5 +213,34 @@ suite("txn_insert") {
order_qt_select23 """select * from ${table}_1"""
order_qt_select24 """select * from ${table}_2"""
}

// 7. update stmt
if (use_nereids_planner) {
def ut_table = "txn_insert_ut"
for (def i in 1..2) {
def tableName = ut_table + "_" + i
sql """ DROP TABLE IF EXISTS ${tableName} """
sql """
CREATE TABLE ${tableName} (
`ID` int(11) NOT NULL,
`NAME` varchar(100) NULL,
`score` int(11) NULL
) ENGINE=OLAP
unique KEY(`id`)
COMMENT 'OLAP'
DISTRIBUTED BY HASH(`id`) BUCKETS 1
PROPERTIES (
"replication_num" = "1"
);
"""
}
sql """ insert into ${ut_table}_1 values(1, "a", 100); """
sql """ begin; """
sql """ insert into ${ut_table}_2 select * from ${ut_table}_1; """
sql """ update ${ut_table}_1 set score = 101 where id = 1; """
sql """ commit; """
order_qt_select25 """select * from ${ut_table}_1 """
order_qt_select26 """select * from ${ut_table}_2 """
}
}
}