[Improve](expr)first support array_contains for expr push down inverted index#32620
Merged
eldenmoon merged 21 commits intoapache:masterfrom Apr 29, 2024
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return true; | ||
| } | ||
|
|
||
| bool SegmentIterator::_check_apply_by_inverted_index(ColumnId col_id) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
|
||
| const std::string& expr_name() const override { return _expr_name; } | ||
|
|
||
| bool is_all_ones(const roaring::Roaring& r) { |
Contributor
There was a problem hiding this comment.
warning: method 'is_all_ones' can be made static [readability-convert-member-functions-to-static]
Suggested change
| bool is_all_ones(const roaring::Roaring& r) { | |
| static bool is_all_ones(const roaring::Roaring& r) { |
| // 2. when meet 'and' conjunct, function with column b can not apply inverted index | ||
| // eg. a and hash(b)=1, if b can apply index, but hash(b)=1 is not for index, so b should not be extracted | ||
| // but a and array_contains(b, 1), b can be applied inverted index, which b can be extracted | ||
| Status eval_inverted_index( |
Contributor
There was a problem hiding this comment.
warning: method 'eval_inverted_index' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status eval_inverted_index( | |
| static Status eval_inverted_index( |
be/src/vec/exprs/vcompound_pred.h:74:
- uint32_t num_rows, roaring::Roaring* bitmap) const override {
+ uint32_t num_rows, roaring::Roaring* bitmap) override {| std::vector<size_t>& args) override; | ||
| Status eval_inverted_index( | ||
| VExprContext* context, | ||
| const std::unordered_map<ColumnId, std::pair<vectorized::NameAndTypePair, |
Contributor
There was a problem hiding this comment.
warning: parameter 2 is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
Suggested change
| const std::unordered_map<ColumnId, std::pair<vectorized::NameAndTypePair, | |
| std::unordered_map<ColumnId, std::pair<vectorized::NameAndTypePair, |
| * @return status not ok means execute failed. | ||
| */ | ||
| [[nodiscard]] Status eval_inverted_indexs( | ||
| const std::unordered_map<ColumnId, std::pair<vectorized::NameAndTypePair, |
Contributor
There was a problem hiding this comment.
warning: parameter 1 is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
Suggested change
| const std::unordered_map<ColumnId, std::pair<vectorized::NameAndTypePair, | |
| std::unordered_map<ColumnId, std::pair<vectorized::NameAndTypePair, |
| return Status::OK(); | ||
| } | ||
|
|
||
| Status eval_inverted_index(FunctionContext* context, |
Contributor
There was a problem hiding this comment.
warning: method 'eval_inverted_index' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status eval_inverted_index(FunctionContext* context, | |
| static Status eval_inverted_index(FunctionContext* context, |
be/src/vec/functions/function.h:411:
- roaring::Roaring* bitmap) const override {
+ roaring::Roaring* bitmap) override {
xiaokang
reviewed
Apr 3, 2024
HappenLee
reviewed
Apr 7, 2024
amorynan
commented
Apr 8, 2024
xiaokang
reviewed
Apr 12, 2024
| // 2. when meet 'and' conjunct, function with column b can not apply inverted index | ||
| // eg. a and hash(b)=1, if b can apply index, but hash(b)=1 is not for index, so b should not be extracted | ||
| // but a and array_contains(b, 1), b can be applied inverted index, which b can be extracted | ||
| Status eval_inverted_index( |
Contributor
There was a problem hiding this comment.
warning: method 'eval_inverted_index' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status eval_inverted_index( | |
| static Status eval_inverted_index( |
be/src/vec/exprs/vcompound_pred.h:64:
- uint32_t num_rows, roaring::Roaring* bitmap) const override {
+ uint32_t num_rows, roaring::Roaring* bitmap) override {| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| #include <gtest/gtest-message.h> |
Contributor
There was a problem hiding this comment.
warning: 'gtest/gtest-message.h' file not found [clang-diagnostic-error]
#include <gtest/gtest-message.h>
^
airborne12
reviewed
Apr 17, 2024
| return create_query_value<TYPE_STRING>(value, result_param); | ||
| case PrimitiveType::TYPE_IPV4: | ||
| return create_query_value<TYPE_IPV4>(value, result_param); | ||
| case PrimitiveType::TYPE_IPV6: |
Member
There was a problem hiding this comment.
we do not support HLL/IPV6/IPV4 type for inverted index
airborne12
reviewed
Apr 17, 2024
| std::unordered_map<ColumnId, std::pair<vectorized::NameAndTypePair, InvertedIndexIterator*>> | ||
| iter_map; | ||
|
|
||
| for (auto col_id : _common_expr_columns) { |
Member
There was a problem hiding this comment.
how about those non-array expr be processed in this situation?
Contributor
Author
There was a problem hiding this comment.
just will return NotSupport
xiaokang
reviewed
Apr 18, 2024
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 37236 ms |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
eldenmoon
reviewed
Apr 28, 2024
eldenmoon
reviewed
Apr 28, 2024
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
TPC-DS: Total hot run time: 186909 ms |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run p0 |
Contributor
Author
|
run external |
eldenmoon
reviewed
Apr 28, 2024
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 41665 ms |
TPC-DS: Total hot run time: 186120 ms |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
in this pr we will do:
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...