Skip to content

[opt](profile) Disable show query/load profile stmt#32467

Merged
yiguolei merged 4 commits intoapache:masterfrom
zhiqiang-hhhh:profile-disable-show
Mar 26, 2024
Merged

[opt](profile) Disable show query/load profile stmt#32467
yiguolei merged 4 commits intoapache:masterfrom
zhiqiang-hhhh:profile-disable-show

Conversation

@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor

@zhiqiang-hhhh zhiqiang-hhhh commented Mar 19, 2024 •
edited
Loading

show query/load profile from terminal is actually not a well maintained feature, and our execution model changed a lot in 2.1 which introduced new execution engine, it will cost much to keep show profile stmt work with new execution engine.

So, we disable it, and user will get a prompt to guide them get profile from web browser like bellow

show load profile "/512b998305c3455d-9e8ea49e520486a6"
--------------

ERROR 1105 (HY000): errCode = 2, detailMessage = try visit http://127.0.0.1:5937/QueryProfile//512b998305c3455d-9e8ea49e520486a6, show query/load profile syntax is a deprecated feature

TODO: maybe we need explain analyze like https://dev.mysql.com/blog-archive/mysql-explain-analyze/

@doris-robot
Copy link
Copy Markdown

doris-robot commented Mar 19, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhiqiang-hhhh zhiqiang-hhhh changed the title [disable feature](show profile) Disable show query/load profile stmt Disable show query/load profile stmt Mar 19, 2024
@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor Author

zhiqiang-hhhh commented Mar 19, 2024

run compile

@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor Author

zhiqiang-hhhh commented Mar 19, 2024

run compile

@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor Author

zhiqiang-hhhh commented Mar 19, 2024

run buildall

@zhiqiang-hhhh zhiqiang-hhhh marked this pull request as ready for review March 20, 2024 02:14
@morrySnow morrySnow changed the title Disable show query/load profile stmt [opt](proc) Disable show query/load profile stmt Mar 20, 2024
@morrySnow morrySnow changed the title [opt](proc) Disable show query/load profile stmt [opt](profile) Disable show query/load profile stmt Mar 20, 2024
morrySnow
morrySnow reviewed Mar 20, 2024
View reviewed changes
Comment thread fe/fe-core/src/main/java/org/apache/doris/qe/ShowExecutor.java
String selfHost = Env.getCurrentEnv().getSelfNode().getHost();
int httpPort = Config.http_port;
String terminalMsg = String.format(
"try visit http://%s:%d/QueryProfile, show query/load profile syntax is a deprecated feature",
Copy link
Copy Markdown
Contributor

@morrySnow morrySnow Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to ensure it could return a visitable url for user. for example, doris behind a net gateway, and user have no access privilege for it

Copy link
Copy Markdown
Contributor Author

@zhiqiang-hhhh zhiqiang-hhhh Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to ensure it could return a visitable url for user. for example, doris behind a net gateway, and user have no access privilege for it

no guarantee for now. this can be fixed by introduce a new syntax like explain analyze

yiguolei
yiguolei approved these changes Mar 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 22, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 22, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 22, 2024

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit d77ca72 into apache:master Mar 26, 2024
@yiguolei yiguolei mentioned this pull request Mar 26, 2024
Closed
@zhiqiang-hhhh zhiqiang-hhhh mentioned this pull request Mar 26, 2024
Merged
zhiqiang-hhhh added a commit to zhiqiang-hhhh/doris that referenced this pull request Mar 26, 2024
@zhiqiang-hhhh
[opt](profile) Disable show query/load profile stmt (apache#32467)
3e0671e
@zhiqiang-hhhh zhiqiang-hhhh deleted the profile-disable-show branch March 26, 2024 03:14
yiguolei pushed a commit that referenced this pull request Mar 26, 2024
@zhiqiang-hhhh
[opt](profile) Disable show query/load profile stmt (#32467) (#32813)
6f47055
@zhiqiang-hhhh zhiqiang-hhhh mentioned this pull request Mar 26, 2024
Merged
@zh0122 zh0122 mentioned this pull request May 31, 2024
Closed
3 tasks
zhiqiang-hhhh added a commit to zhiqiang-hhhh/doris that referenced this pull request Jan 2, 2025
@zhiqiang-hhhh
Revert "[opt](profile) Disable show query/load profile stmt (apache#3…
b7dd411 
…2467)"

This reverts commit d77ca72.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. kind/behavior-changed reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhiqiang-hhhh @doris-robot @yiguolei @morrySnow