Skip to content

[Refactor](executor)Add information_schema.workload_groups#32195

Merged
yiguolei merged 2 commits intoapache:masterfrom
wangbo:0313_add_schema_tab_wg
Mar 14, 2024
Merged

[Refactor](executor)Add information_schema.workload_groups#32195
yiguolei merged 2 commits intoapache:masterfrom
wangbo:0313_add_schema_tab_wg

Conversation

@wangbo
Copy link
Copy Markdown
Contributor

@wangbo wangbo commented Mar 13, 2024

Proposed changes

Add information_schema.workload_groups.

@wangbo
Copy link
Copy Markdown
Contributor Author

wangbo commented Mar 13, 2024

run buildall

@doris-robot
Copy link
Copy Markdown

doris-robot commented Mar 13, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@doris-robot
Copy link
Copy Markdown

doris-robot commented Mar 13, 2024

TPC-H: Total hot run time: 38191 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4f3448a080b92fcd67561d923677bda076f93d59, data reload: false

------ Round 1 ----------------------------------
q1	17621	4928	4112	4112
q2	2023	155	145	145
q3	10592	1052	890	890
q4	8123	816	713	713
q5	7487	2730	2659	2659
q6	185	123	123	123
q7	1188	832	813	813
q8	9350	2039	1962	1962
q9	7201	6440	6384	6384
q10	8490	3510	3625	3510
q11	427	222	221	221
q12	626	308	297	297
q13	17829	2837	2870	2837
q14	274	241	256	241
q15	514	462	450	450
q16	513	393	388	388
q17	954	627	543	543
q18	7170	6543	6468	6468
q19	4868	1411	1394	1394
q20	531	297	274	274
q21	6439	3477	3542	3477
q22	348	290	313	290
Total cold run time: 112753 ms
Total hot run time: 38191 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4124	4103	4094	4094
q2	321	219	233	219
q3	2961	2859	2841	2841
q4	1832	1518	1523	1518
q5	5212	5204	5235	5204
q6	188	115	115	115
q7	2207	1848	1878	1848
q8	3142	3288	3314	3288
q9	8579	8565	8584	8565
q10	3717	3655	3668	3655
q11	549	440	444	440
q12	718	531	545	531
q13	16917	2850	2850	2850
q14	285	239	272	239
q15	477	442	448	442
q16	462	407	431	407
q17	1744	1477	1472	1472
q18	7562	7252	7123	7123
q19	1604	1522	1524	1522
q20	1888	1717	1718	1717
q21	4667	4541	4653	4541
q22	548	428	455	428
Total cold run time: 69704 ms
Total hot run time: 53059 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Mar 13, 2024

TeamCity be ut coverage result:
Function Coverage: 34.99% (8575/24504)
Line Coverage: 26.75% (69464/259713)
Region Coverage: 26.02% (36067/138639)
Branch Coverage: 22.97% (18417/80170)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4f3448a080b92fcd67561d923677bda076f93d59_4f3448a080b92fcd67561d923677bda076f93d59/report/index.html

yiguolei
yiguolei reviewed Mar 14, 2024
View reviewed changes
Comment thread fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
// tvf queries
if (request.getSchemaTableName() == TSchemaTableName.METADATA_TABLE) {
return MetadataGenerator.getMetadataTable(request);
} else {
Copy link
Copy Markdown
Contributor

@yiguolei yiguolei Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to else if (request.getSchemaTableName() == TSchemaTableName.INFORMATION_SCHEMA) {

    } else {
            throw new TException("xxxxx")
    }

Then we could make sure if we add another ENUM, the logic will not be wrong.

@wangbo
Copy link
Copy Markdown
Contributor Author

wangbo commented Mar 14, 2024

run buildall

@wangbo wangbo force-pushed the 0313_add_schema_tab_wg branch from 299d79d to 8c091d0 Compare March 14, 2024 02:51
@wangbo
Copy link
Copy Markdown
Contributor Author

wangbo commented Mar 14, 2024

run buildall

@doris-robot
Copy link
Copy Markdown

doris-robot commented Mar 14, 2024

TPC-H: Total hot run time: 38217 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8c091d057375ae2e6f5dca25772d8a12ec3b40bf, data reload: false

------ Round 1 ----------------------------------
q1	17652	4223	4098	4098
q2	2018	150	142	142
q3	10605	1094	887	887
q4	6739	713	695	695
q5	7453	2680	2752	2680
q6	193	128	127	127
q7	1156	818	795	795
q8	9342	2011	1989	1989
q9	7071	6393	6383	6383
q10	8528	3538	3638	3538
q11	422	222	214	214
q12	675	303	287	287
q13	17789	2864	2834	2834
q14	266	245	248	245
q15	500	456	458	456
q16	496	392	381	381
q17	940	547	544	544
q18	7045	6385	6381	6381
q19	6279	1472	1398	1398
q20	542	292	288	288
q21	6449	3541	3544	3541
q22	373	334	314	314
Total cold run time: 112533 ms
Total hot run time: 38217 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4132	4103	4098	4098
q2	319	237	224	224
q3	2966	2827	2842	2827
q4	1838	1567	1542	1542
q5	5205	5243	5202	5202
q6	193	122	118	118
q7	2234	1811	1837	1811
q8	3174	3267	3274	3267
q9	8565	8527	8542	8527
q10	3703	3727	3684	3684
q11	532	436	436	436
q12	736	593	543	543
q13	16899	2883	2871	2871
q14	275	239	269	239
q15	478	455	439	439
q16	471	401	400	400
q17	1711	1484	1463	1463
q18	7365	7167	7044	7044
q19	1598	1564	1552	1552
q20	1899	1705	1695	1695
q21	4831	4796	4742	4742
q22	522	444	461	444
Total cold run time: 69646 ms
Total hot run time: 53168 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Mar 14, 2024

TeamCity be ut coverage result:
Function Coverage: 35.00% (8576/24504)
Line Coverage: 26.76% (69487/259713)
Region Coverage: 26.02% (36077/138639)
Branch Coverage: 22.98% (18426/80170)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8c091d057375ae2e6f5dca25772d8a12ec3b40bf_8c091d057375ae2e6f5dca25772d8a12ec3b40bf/report/index.html

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 14, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 14, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 14, 2024

PR approved by anyone and no changes requested.

xinyiZzz
xinyiZzz approved these changes Mar 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit ace7792 into apache:master Mar 14, 2024
wangbo added a commit to wangbo/incubator-doris that referenced this pull request Mar 15, 2024
@wangbo
[Refactor](executor)Add information_schema.workload_groups (apache#32195
49991f1 
)
@wangbo wangbo mentioned this pull request Mar 15, 2024
Merged
wangbo added a commit to wangbo/incubator-doris that referenced this pull request Mar 15, 2024
@wangbo
[Refactor](executor)Add information_schema.workload_groups (apache#32195
4cf3027 
)
yiguolei pushed a commit that referenced this pull request Mar 15, 2024
@wangbo
[Refactor](executor)Add information_schema.workload_groups (#32195) (#…
258dcfc 
…32314)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@yiguolei yiguolei yiguolei approved these changes

@xinyiZzz xinyiZzz xinyiZzz approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. kind/behavior-changed meta-change reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wangbo @doris-robot @morningman @yiguolei @xinyiZzz