[enhance](Cooldown) Skip cooldown if the tablet is dropped#32079
Merged
dataroaring merged 1 commit intoapache:masterfrom Mar 12, 2024
Merged
[enhance](Cooldown) Skip cooldown if the tablet is dropped#32079dataroaring merged 1 commit intoapache:masterfrom
dataroaring merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. |
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38084 ms |
TPC-DS: Total hot run time: 186674 ms |
ClickBench: Total hot run time: 30.21 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
gavinchou
approved these changes
Mar 12, 2024
yiguolei
pushed a commit
that referenced
this pull request
Mar 12, 2024
dataroaring
pushed a commit
that referenced
this pull request
Mar 13, 2024
Closed
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Formerly the cooldown meta write task would continue doing no matter the tablet is dropped or not. It serves well under most circumstances, while it would end up with endless retrying if the corresponding storage policy is dropped neither. Which means the logic would be as follows:
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...