[enhancement](Nereids) Speedup PartitionPrunner#31970
Merged
morrySnow merged 2 commits intoapache:masterfrom Mar 8, 2024
Merged
[enhancement](Nereids) Speedup PartitionPrunner#31970morrySnow merged 2 commits intoapache:masterfrom
morrySnow merged 2 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. |
Contributor
Author
|
run buildall |
|
Any performance data? |
924060929
force-pushed
the
optimize_partition_prunner
branch
from
5d0a639 to
08c4e0f
Compare
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
100 threads parallel continuous send this sql which query an empty table, test in my mac machine(m2 chip, 8 core) select count(1),date_format(time_col,'%Y%m%d'),varchar_col1
from tbl
where partition_date>'2024-02-15' and (varchar_col2 ='73130' or varchar_col3='73130') and time_col>'2024-03-04'
and time_col<'2024-03-05'
group by date_format(time_col,'%Y%m%d'),varchar_col1
order by date_format(time_col,'%Y%m%d') desc, varchar_col1 desc,count(1) asc
limit 1000before: 1600 peak QPS, about 1300 avg QPS |
morrySnow
approved these changes
Mar 8, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
starocean999
approved these changes
Mar 8, 2024
starocean999
reviewed
Mar 8, 2024
| this.slotToType = IntStream.range(0, partitionSlots.size()) | ||
| .mapToObj(index -> Pair.of(partitionSlots.get(index), partitionSlotTypes.get(index))) | ||
| .collect(ImmutableMap.toImmutableMap(Pair::key, Pair::value)); | ||
| this.slotToType = Maps.newHashMapWithExpectedSize(partitionSlots.size() * 2); |
Contributor
There was a problem hiding this comment.
Minor: use Maps.newHashMapWithExpectedSize(partitionSlots.size()); may good enough, can update the code in next pr
Contributor
Author
There was a problem hiding this comment.
I will change to 16 in next pr, because the num of partitionSlots usually <= 3
yiguolei
pushed a commit
that referenced
this pull request
Mar 9, 2024
This pr imporve the high QPS query by speed up PartitionPrunner 1. remove useless Date parse/format, use LocalDate instead 2. fast evaluate path for single value partition 3. change Collection.stream() to ImmutableXxx.builderWithExpectedSize(n) to skip useless method call and collection resize 4. change lots of if-else to switch 5. don't parse to string to compare dateLiteral, use int field compare instead
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pr imporve the high QPS query by speed up PartitionPrunner
LocalDateinsteadCollection.stream()toImmutableXxx.builderWithExpectedSize(n)to skip useless method call and collection resize