[Refactor](admin-stmt) rename some admin-show statestmt#29492
Merged
zy-kkk merged 4 commits intoapache:masterfrom Jan 10, 2024
Merged
[Refactor](admin-stmt) rename some admin-show statestmt#29492zy-kkk merged 4 commits intoapache:masterfrom
admin-show statestmt#29492zy-kkk merged 4 commits intoapache:masterfrom
Conversation
morningman
changed the title
admin-show statestmtadmin-show statestmt
Contributor
Author
|
run buildall |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
|
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools |
|
TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
morningman
force-pushed
the
remove_admin
branch
from
d4771cb to
44dbe4d
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38673 ms |
TPC-DS: Total hot run time: 184159 ms |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
wuwenchi
approved these changes
Jan 10, 2024
Member
|
run pipelinex |
SailorShen
approved these changes
Jan 10, 2024
yiguolei
pushed a commit
that referenced
this pull request
Jan 12, 2024
The `ADMIN SHOW` statement can not be executed with high version of mysql 8.x jdbc driver. So I rename these statement, remove the `ADMIN` keywords. 1. ADMIN SHOW CONFIG -> SHOW CONFIG 2. ADMIN SHOW REPLICA -> SHOW REPLICA 3. ADMIN DIAGNOSE TABLET -> SHOW TABLET DIAGNOSIS 4. ADMIN SHOW TABLET -> SHOW TABLET for compatibility, the old statements are still supported, but not recommend to use. They will be removed in later version
morningman
added a commit
to morningman/doris
that referenced
this pull request
Mar 28, 2024
The `ADMIN SHOW` statement can not be executed with high version of mysql 8.x jdbc driver. So I rename these statement, remove the `ADMIN` keywords. 1. ADMIN SHOW CONFIG -> SHOW CONFIG 2. ADMIN SHOW REPLICA -> SHOW REPLICA 3. ADMIN DIAGNOSE TABLET -> SHOW TABLET DIAGNOSIS 4. ADMIN SHOW TABLET -> SHOW TABLET for compatibility, the old statements are still supported, but not recommend to use. They will be removed in later version
morningman
added a commit
that referenced
this pull request
Mar 29, 2024
Closed
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The
ADMIN SHOWstatement can not be executed with high version of mysql 8.x jdbc driver.So I rename these statement, remove the
ADMINkeywords.for compatibility, the old statements are still supported, but not recommend to use.
They will be removed in later version
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...