Skip to content

[opt](inverted index) Add null document interface to optimize empty s… #28661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qidaye merged 1 commit into from
Dec 20, 2023
Merged

[opt](inverted index) Add null document interface to optimize empty s… #28661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion be/src/clucene
Open in desktop
Submodule clucene updated 5 files
+5 −0 src/core/CLucene/index/IndexWriter.cpp
+4 −0 src/core/CLucene/index/IndexWriter.h
+9 −0 src/core/CLucene/index/SDocumentWriter.cpp
+4 −0 src/core/CLucene/index/SDocumentWriter.h
+1 −0 src/core/CLucene/index/_DocumentsWriter.h
19 changes: 16 additions & 3 deletions be/src/olap/rowset/segment_v2/inverted_index_writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,17 @@ class InvertedIndexColumnWriterImpl : public InvertedIndexColumnWriter {
return Status::OK();
}

Status add_null_document() {
try {
_index_writer->addNullDocument(_doc.get());
} catch (const CLuceneError& e) {
_dir->deleteDirectory();
return Status::Error<ErrorCode::INVERTED_INDEX_CLUCENE_ERROR>(
"CLuceneError add_null_document: {}", e.what());
}
return Status::OK();
}

Status add_nulls(uint32_t count) override {
_null_bitmap.addRange(_rid, _rid + count);
_rid += count;
Expand All @@ -242,7 +253,7 @@ class InvertedIndexColumnWriterImpl : public InvertedIndexColumnWriter {

for (int i = 0; i < count; ++i) {
new_fulltext_field(empty_value.c_str(), 0);
RETURN_IF_ERROR(add_document());
RETURN_IF_ERROR(add_null_document());
}
}
return Status::OK();
Expand Down Expand Up @@ -292,10 +303,11 @@ class InvertedIndexColumnWriterImpl : public InvertedIndexColumnWriter {
VLOG_DEBUG << "fulltext index value length can be at most 256, but got "
<< "value length:" << v->get_size() << ", ignore this value";
new_fulltext_field(empty_value.c_str(), 0);
RETURN_IF_ERROR(add_null_document());
} else {
new_fulltext_field(v->get_data(), v->get_size());
RETURN_IF_ERROR(add_document());
}
RETURN_IF_ERROR(add_document());
++v;
_rid++;
}
Expand Down Expand Up @@ -341,11 +353,12 @@ class InvertedIndexColumnWriterImpl : public InvertedIndexColumnWriter {
VLOG_DEBUG << "fulltext index value length can be at most 256, but got "
<< "value length:" << value.length() << ", ignore this value";
new_fulltext_field(empty_value.c_str(), 0);
RETURN_IF_ERROR(add_null_document());
} else {
new_fulltext_field(value.c_str(), value.length());
RETURN_IF_ERROR(add_document());
}
_rid++;
RETURN_IF_ERROR(add_document());
}
} else if constexpr (field_is_numeric_type(field_type)) {
for (int i = 0; i < count; ++i) {
Expand Down