Skip to content

[Fix](memtable) fix shrink_memtable_by_agg without duplicated keys #28660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eldenmoon merged 1 commit into from
Dec 19, 2023
Merged

[Fix](memtable) fix shrink_memtable_by_agg without duplicated keys #28660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions be/src/olap/memtable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,10 +468,7 @@ void MemTable::shrink_memtable_by_agg() {
return;
}
size_t same_keys_num = _sort();
if (same_keys_num == 0) {
vectorized::Block in_block = _input_mutable_block.to_block();
_put_into_output(in_block);
} else {
if (same_keys_num != 0) {
_aggregate<false>();
}
}
Expand Down
2 changes: 2 additions & 0 deletions regression-test/suites/load_p0/insert/test_insert_with_aggregation_memtable.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,8 @@ suite("test_insert_with_aggregation_memtable", "nonConcurrent") {
sql """INSERT INTO ${table_name} SELECT k, v from ${table_name}"""
createMV("""create materialized view var_cnt as select k, count(k) from ${table_name} group by k""")
sql """INSERT INTO ${table_name} SELECT k, v from ${table_name} limit 8101"""
// insert with no duplicate
sql """INSERT INTO ${table_name} SELECT *, '{"k1":1, "k2": "hello world", "k3" : [1234], "k4" : 1.10000, "k5" : [[123]]}' FROM numbers("number" = "4096"); """

reset_be_param("enable_shrink_memory")
reset_be_param("write_buffer_size_for_agg")
Expand Down