[Fix](from_unixtime) Keep consistent with MySQL & bug fix (#25966)#28649
[Fix](from_unixtime) Keep consistent with MySQL & bug fix (#25966)#28649xiaokang merged 1 commit intoapache:branch-2.0from
Conversation
Bug fix: implicit convert from int32 -> int64 makes negative time stamp valid, so change signature to int64 Consistent: keep consistent with mysql. (cherry picked from commit 0449a24)
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
Proposed changes
Bug fix: implicit convert from int32 -> int64 makes negative time stamp valid, so change signature to int64
Consistent: keep consistent with mysql.
(cherry picked from commit 0449a24)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...