[improvement](compaction) be do not compact invisible version to avoid query error -230#28082
Merged
dataroaring merged 1 commit intoapache:masterfrom Apr 28, 2024
Merged
Conversation
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -20,6 +20,7 @@ | |||
| #include <gen_cpp/Types_types.h> | |||
Contributor
There was a problem hiding this comment.
warning: 'gen_cpp/Types_types.h' file not found [clang-diagnostic-error]
#include <gen_cpp/Types_types.h>
^
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
yujun777
force-pushed
the
fix-230-2
branch
2 times, most recently
from
344f627 to
13ab608
Compare
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
Contributor
Author
|
run buildall |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
| return max_version; | ||
| } | ||
|
|
||
| size_t TabletMeta::version_count_cross_with_range(const Version& range) const { |
Contributor
There was a problem hiding this comment.
warning: method 'version_count_cross_with_range' can be made static [readability-convert-member-functions-to-static]
Suggested change
| size_t TabletMeta::version_count_cross_with_range(const Version& range) const { | |
| size_t TabletMeta::version_count_cross_with_range(const Version& range) { |
be/src/olap/tablet_meta.h:165:
- size_t version_count_cross_with_range(const Version& range) const;
+ static size_t version_count_cross_with_range(const Version& range) ;
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H: Total hot run time: 38580 ms |
TPC-DS: Total hot run time: 183392 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39165 ms |
TPC-DS: Total hot run time: 185899 ms |
ClickBench: Total hot run time: 30.13 s |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run p0 |
2 similar comments
Contributor
Author
|
run p0 |
Contributor
Author
|
run p0 |
Contributor
Author
|
run buildall |
Contributor
Author
|
run feut |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run external |
dataroaring
requested changes
Apr 26, 2024
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 187078 ms |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
deardeng
approved these changes
Apr 28, 2024
|
|
||
| using PartialUpdateReadPlan = std::map<RowsetId, std::map<uint32_t, std::vector<RidAndPos>>>; | ||
|
|
||
| // used for controll compaction |
| continue; | ||
| } | ||
|
|
||
| // can compact, met one of the conditions: |
| row.add(String.valueOf(visibleVersion)); | ||
| row.add(String.valueOf(replica.getSchemaHash())); | ||
| row.add(String.valueOf(replica.getVersionCount())); | ||
| row.add(String.valueOf(replica.getTotalVersionCount())); |
Collaborator
There was a problem hiding this comment.
visible version count 不用加么？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When execute a sql query, FE will send a request to BE. The request contains tablets and their partitions' visible versions. BE need to obtains the tablet's rowsets in range [0, visible version]. But sometimes BE may had compacted visible version rowset with large version rowsets, so it can not return rowsets just in range [0, visible version]. Then BE will return error VERSION_ALREADY_MERGED -230.
Fix:
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...