[feature](nereids) Support to get partition related table from mv and check the query operator#28064
Merged
morrySnow merged 3 commits intoapache:masterfrom Dec 6, 2023
Merged
Conversation
… check the query operator
Member
Author
|
run buildall |
zddr
reviewed
Dec 6, 2023
| * @param materializedViewPlan this should be rewritten or analyzed plan, should not be physical plan. | ||
| * @param column ref column name. | ||
| */ | ||
| public static RelatedTableInfo getRelatedTableInfo(String column, Plan materializedViewPlan) { |
Contributor
There was a problem hiding this comment.
The return value may be empty, is Optional more appropriate?
| */ | ||
| public static final class RelatedTableInfo { | ||
| private BaseTableInfo tableInfo; | ||
| private boolean pctPossible; |
Member
Author
There was a problem hiding this comment.
pct: partition change tracking， if true can partition increment build or not
Member
Author
|
run buildall |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
keanji-x
approved these changes
Dec 6, 2023
morrySnow
approved these changes
Dec 6, 2023
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
XuJianxu
pushed a commit
to XuJianxu/doris
that referenced
this pull request
Dec 14, 2023
… check the query operator (apache#28064) Function 1: check the select query plan is contain the stmt as following or not SELECT [hint_statement, ...] [ALL | DISTINCT | DISTINCTROW | ALL EXCEPT ( col_name1 [, col_name2, col_name3, ...] )] elect_expr [, select_expr ...] [FROM table_references PARTITION partition_list] [TABLET tabletid_list] [TABLESAMPLE sample_value [ROWS | PERCENT] [REPEATABLE pos_seek]] [WHERE where_condition] [GROUP BY [GROUPING SETS | ROLLUP | CUBE] {col_name | expr | position}] [HAVING where_condition] [ORDER BY {col_name | expr | position} [ASC | DESC], ...] [LIMIT {[offset,] row_count | row_count OFFSET offset}] [INTO OUTFILE 'file_name'] if analyzedPlan contains the stmt as following [PARTITION partition_list] [TABLET tabletid_list] or [TABLESAMPLE sample_value [ROWS | PERCENT] [REPEATABLE pos_seek]] this method will return true. Function 2: Get related base table info which materialized view plan column reference, input param plan should be rewritten plan that sub query should be eliminated
16 tasks
morrySnow
pushed a commit
that referenced
this pull request
Dec 2, 2024
…LESAMPLE or tablet and so on (#43030) Related PR: #28064 Materialized view is as following: CREATE MATERIALIZED VIEW mv1 BUILD IMMEDIATE REFRESH AUTO ON MANUAL DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ('replication_num' = '1') AS select * from orders If run query as following, should rewrite fail by materialized view above to make sure data correctness select * from orders TABLET(110); select * from orders index query_index_test; select * from orders TABLESAMPLE(20 percent); select * from orders_partition PARTITION (day_2); At before, this would rewrite by materialized view succesfully and the result data is wrong, This pr fix this.
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
…LESAMPLE or tablet and so on (#43030) Related PR: #28064 Materialized view is as following: CREATE MATERIALIZED VIEW mv1 BUILD IMMEDIATE REFRESH AUTO ON MANUAL DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ('replication_num' = '1') AS select * from orders If run query as following, should rewrite fail by materialized view above to make sure data correctness select * from orders TABLET(110); select * from orders index query_index_test; select * from orders TABLESAMPLE(20 percent); select * from orders_partition PARTITION (day_2); At before, this would rewrite by materialized view succesfully and the result data is wrong, This pr fix this.
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Dec 6, 2024
…LESAMPLE or tablet and so on (apache#43030) Related PR: apache#28064 Materialized view is as following: CREATE MATERIALIZED VIEW mv1 BUILD IMMEDIATE REFRESH AUTO ON MANUAL DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ('replication_num' = '1') AS select * from orders If run query as following, should rewrite fail by materialized view above to make sure data correctness select * from orders TABLET(110); select * from orders index query_index_test; select * from orders TABLESAMPLE(20 percent); select * from orders_partition PARTITION (day_2); At before, this would rewrite by materialized view succesfully and the result data is wrong, This pr fix this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Function 1
check the select query plan is contain the stmt as following or not
Function 2
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...