Skip to content

[branch-2.0](pick) Common expression not acting on any slot should not be pushed down #25901#26215

Merged
xiaokang merged 1 commit intoapache:branch-2.0from
zhiqiang-hhhh:pick-25901
Nov 1, 2023
Merged

[branch-2.0](pick) Common expression not acting on any slot should not be pushed down #25901#26215
xiaokang merged 1 commit intoapache:branch-2.0from
zhiqiang-hhhh:pick-25901

Conversation

@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor

pick #25901

@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 1, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 38.24% (7933/20743)
Line Coverage: 30.05% (64139/213471)
Region Coverage: 29.27% (33229/113544)
Branch Coverage: 25.08% (17073/68070)
Coverage Report: http://coverage.selectdb-in.cc/coverage/548c56c2743a4831824a81abc202dc8a19d6e5f3_548c56c2743a4831824a81abc202dc8a19d6e5f3/report/index.html

@doris-robot
Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.24 seconds
stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162947495 Bytes

@zhiqiang-hhhh zhiqiang-hhhh changed the title [charrypick](predicate pushdown) Common expression not acting on any slot should not be pushed down [Bugifx](pick #25901) Common expression not acting on any slot should not be pushed down Nov 1, 2023
@zhiqiang-hhhh zhiqiang-hhhh changed the title [Bugifx](pick #25901) Common expression not acting on any slot should not be pushed down [Bugfix](pick #25901) Common expression not acting on any slot should not be pushed down Nov 1, 2023
@zhiqiang-hhhh zhiqiang-hhhh changed the title [Bugfix](pick #25901) Common expression not acting on any slot should not be pushed down [branch-2.0](pick) Common expression not acting on any slot should not be pushed down #25901 Nov 1, 2023
@xiaokang xiaokang merged commit 104721d into apache:branch-2.0 Nov 1, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants