Skip to content

[minor](planner) remove len on integral type toSql#25951

Merged
morrySnow merged 1 commit intoapache:masterfrom
morrySnow:remove_len_on_integral_to_sql
Oct 31, 2023
Merged

[minor](planner) remove len on integral type toSql#25951
morrySnow merged 1 commit intoapache:masterfrom
morrySnow:remove_len_on_integral_to_sql

Conversation

@morrySnow
Copy link
Copy Markdown
Contributor

@morrySnow morrySnow commented Oct 26, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow
Copy link
Copy Markdown
Contributor Author

morrySnow commented Oct 26, 2023

run buildall

@doris-robot
Copy link
Copy Markdown

doris-robot commented Oct 26, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.74 seconds
stream load tsv: 557 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162163025 Bytes

@morrySnow morrySnow force-pushed the remove_len_on_integral_to_sql branch 2 times, most recently from 9f0a345 to 0065491 Compare October 30, 2023 07:53
@morrySnow
Copy link
Copy Markdown
Contributor Author

morrySnow commented Oct 30, 2023

run buildall

@doris-robot
Copy link
Copy Markdown

doris-robot commented Oct 30, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.52 seconds
stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162313039 Bytes

@morrySnow morrySnow force-pushed the remove_len_on_integral_to_sql branch from 0065491 to 68f722d Compare October 30, 2023 11:24
@morrySnow
Copy link
Copy Markdown
Contributor Author

morrySnow commented Oct 30, 2023

run buildall

@doris-robot
Copy link
Copy Markdown

doris-robot commented Oct 30, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.97 seconds
stream load tsv: 559 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17161991231 Bytes

starocean999
starocean999 previously approved these changes Oct 31, 2023
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 31, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 31, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 31, 2023

PR approved by anyone and no changes requested.

@morrySnow morrySnow force-pushed the remove_len_on_integral_to_sql branch from 68f722d to e83e634 Compare October 31, 2023 03:46
@morrySnow
Copy link
Copy Markdown
Contributor Author

morrySnow commented Oct 31, 2023

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 31, 2023
@doris-robot
Copy link
Copy Markdown

doris-robot commented Oct 31, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.62 seconds
stream load tsv: 569 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162646296 Bytes

yiguolei
yiguolei approved these changes Oct 31, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 31, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 31, 2023

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit 111b8e2 into apache:master Oct 31, 2023
@morrySnow morrySnow deleted the remove_len_on_integral_to_sql branch October 31, 2023 10:50
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Oct 31, 2023
@morrySnow
[fix](Nereids) ut failed intro by PR apache#25951
60ba436
@morrySnow morrySnow mentioned this pull request Oct 31, 2023
Merged
morrySnow added a commit that referenced this pull request Nov 1, 2023
@morrySnow
[fix](compile) fe compile failed when generate doc and FE UT failed (#…
18dabe7 
…26164)

1. FE could not compile because below error. Intro by PR #25933
```
[INFO] --- exec:3.1.0:java (doc) @ fe-core ---
...
Failed to generate doc for ignoreRuntimeFilterIds
```

2. fix UT bugs intro by below PRs
> - #25951
> - #26031

3. because fe could not compile, FE UT CI do not work well. So, some UT failed be introduced by the PRs merged after PR #25933 merged. So this PR revert them to fix FE UT

> - Revert "[Bug](materialized-view) SelectMaterializedIndexWithAggregate do not change plan > when match ba… (#26145)"
> This reverts commit 8d7abf6.

> - Revert "[enhancement](Nereids): optimize GroupExpressionMatching (#26130)"
> This reverts commit 19122b5.

> - Revert "[Performance](Nereids): optimize GroupExpressionMatching (#26084)"
> This reverts commit 0d956e9.
dutyu pushed a commit to dutyu/doris that referenced this pull request Nov 4, 2023
@morrySnow
[minor](planner) remove len on integral type toSql (apache#25951)
c37b89a
@feiniaofeiafei feiniaofeiafei mentioned this pull request May 27, 2024
Merged
morrySnow added a commit that referenced this pull request May 27, 2024
@feiniaofeiafei @morrySnow
[Fix](planner) fix create view star except and modify cast to sql (#3…
b1a15f9 
…5324)

cherry-pick #25951 to branch-2.0
cherry-pick #33726 to branch-2.0

---------

Co-authored-by: morrySnow <101034200+morrySnow@users.noreply.github.com>
Co-authored-by: feiniaofeiafei <moailing@selectdb.com>
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Jul 17, 2024
@morrySnow
[fix](compability) type toSql should return lowercase string
26d006e 
revert apache#25951
@morrySnow morrySnow mentioned this pull request Jul 17, 2024
Merged
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Jul 17, 2024
@morrySnow
[fix](compability) type toSql should return lowercase string
e79abe6 
revert apache#25951
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Jul 17, 2024
@morrySnow
[fix](compability) type toSql should return lowercase string
ba7c743 
revert apache#25951
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Jul 18, 2024
@morrySnow
[fix](compability) type toSql should return lowercase string
b70549a 
revert apache#25951
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Jul 18, 2024
@morrySnow
[fix](compability) type toSql should return lowercase string
cb37ad3 
revert apache#25951
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Jul 18, 2024
@morrySnow
[fix](compability) type toSql should return lowercase string
a3b46a1 
revert apache#25951
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Jul 19, 2024
@morrySnow
[fix](compability) type toSql should return lowercase string
b566c6a 
revert apache#25951
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Jul 19, 2024
@morrySnow
[fix](compability) type toSql should return lowercase string
2c9c633 
revert apache#25951
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Jul 19, 2024
@morrySnow
[fix](compability) type toSql should return lowercase string
49e96c9 
revert apache#25951
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Jul 22, 2024
@morrySnow
[fix](compability) type toSql should return lowercase string
80abded 
revert apache#25951
morrySnow added a commit that referenced this pull request Jul 22, 2024
@morrySnow
[fix](compatibility) type toSql should return lowercase string (#38012)
e4ed733 
revert #25951
dataroaring pushed a commit that referenced this pull request Jul 24, 2024
@morrySnow @dataroaring
[fix](compatibility) type toSql should return lowercase string (#38012)
a804d5b 
revert #25951
morrySnow added a commit that referenced this pull request Jul 30, 2024
@morrySnow
[fix](compatibility) type toSql should return lowercase string (#38012)
959d3f6 
pick from master #38012

revert #25951
morrySnow added a commit that referenced this pull request Jul 30, 2024
@morrySnow
[fix](compatibility) type toSql should return lowercase string (#38012)
104c568 
pick from master #38012

revert #25951
@morrySnow morrySnow mentioned this pull request Jul 30, 2024
Merged
morrySnow added a commit that referenced this pull request Jul 30, 2024
@morrySnow
[fix](compatibility) type toSql should return lowercase string (#38012)
9b1810f 
pick from master #38012

revert #25951
morrySnow added a commit that referenced this pull request Jul 31, 2024
@morrySnow
[fix](compatibility) type toSql should return lowercase string (#38012)
b8c80ee 
pick from master #38012

revert #25951
morrySnow added a commit that referenced this pull request Jul 31, 2024
@morrySnow
[fix](compatibility) type toSql should return lowercase string (#38012)
f3fb21b 
pick from master #38012

revert #25951
morrySnow added a commit that referenced this pull request Jul 31, 2024
@morrySnow
[fix](compatibility) type toSql should return lowercase string (#38012)
03fdb45 
pick from master #38012

revert #25951
yiguolei pushed a commit that referenced this pull request Aug 1, 2024
@morrySnow @yiguolei
[fix](compatibility) type toSql should return lowercase string (#38012)
27de814 
pick from master #38012

revert #25951
yiguolei pushed a commit that referenced this pull request Aug 5, 2024
@morrySnow @yiguolei
[fix](compatibility) type toSql should return lowercase string (#38012)
6ea6eb8 
pick from master #38012

revert #25951
morrySnow added a commit that referenced this pull request Aug 8, 2024
@morrySnow
[fix](compatibility) type toSql should return lowercase string (#38012)
f65e837 
pick from master #38012

revert #25951
morrySnow added a commit that referenced this pull request Aug 8, 2024
@morrySnow
[fix](compatibility) type toSql should return lowercase string (#38012)
374eb10 
pick from master #38012

revert #25951
morrySnow added a commit that referenced this pull request Aug 8, 2024
@morrySnow
[fix](compatibility) type toSql should return lowercase string (#38012)
8cd3e69 
pick from master #38012

revert #25951
yiguolei pushed a commit that referenced this pull request Aug 9, 2024
@morrySnow
[fix](compatibility) type toSql should return lowercase string (#38012)…
3c535e8 
… (#38517)

pick from master #38012

revert #25951
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@feiniaofeiafei @morrySnow
[Fix](planner) fix create view star except and modify cast to sql (ap…
a4705e6 
…ache#35324)

cherry-pick apache#25951 to branch-2.0
cherry-pick apache#33726 to branch-2.0

---------

Co-authored-by: morrySnow <101034200+morrySnow@users.noreply.github.com>
Co-authored-by: feiniaofeiafei <moailing@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.11-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morrySnow @doris-robot @yiguolei @starocean999