[improvement](function) improve date_trunc function performance when timeunit is const#25824
[improvement](function) improve date_trunc function performance when timeunit is const#25824yiguolei merged 5 commits intoapache:masterfrom
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
HappenLee
left a comment
There was a problem hiding this comment.
better use function call ptr to replace strncmp? like "re"
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
1893583 to
8268412
Compare
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
PR approved by at least one committer and no changes requested. |
…timeunit is const (apache#25824) this PR apache#22602 have check function. only support date_trunc(column, const), so the second must be const literal and no need to check time unit every row.
…timeunit is const (apache#25824) this PR apache#22602 have check function. only support date_trunc(column, const), so the second must be const literal and no need to check time unit every row.
…timeunit is const (apache#25824) this PR apache#22602 have check function. only support date_trunc(column, const), so the second must be const literal and no need to check time unit every row.
…timeunit is const (apache#25824) this PR apache#22602 have check function. only support date_trunc(column, const), so the second must be const literal and no need to check time unit every row.
…timeunit is const (apache#25824) this PR apache#22602 have check function. only support date_trunc(column, const), so the second must be const literal and no need to check time unit every row.
this PR #22602 have check function.
only support date_trunc(column, const), so the second must be const literal
and no need to check time unit every row.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...