Skip to content

[Fix](partial update) Fix wrong comment in .proto file#25742

Merged
zhannngchen merged 1 commit intoapache:masterfrom
bobhan1:fix-wrong-comment
Oct 23, 2023
Merged

[Fix](partial update) Fix wrong comment in .proto file#25742
zhannngchen merged 1 commit intoapache:masterfrom
bobhan1:fix-wrong-comment

Conversation

@bobhan1
Copy link
Copy Markdown
Contributor

@bobhan1 bobhan1 commented Oct 23, 2023 •
edited
Loading

Proposed changes

  1. remove deprecated comment on fields that is wrongly added in #[refactor](partial-update) Split partial update infos from tablet schema #25147. These fields will be used when coordinator BE send infos to executor BEs. They will only be used during RPC and will not be persisted.
  2. eliminate some unnecessary copys.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@bobhan1
Copy link
Copy Markdown
Contributor Author

bobhan1 commented Oct 23, 2023

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 23, 2023

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1
Copy link
Copy Markdown
Contributor Author

bobhan1 commented Oct 23, 2023

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 23, 2023

clang-tidy review says "All clean, LGTM! 👍"

zhannngchen
zhannngchen approved these changes Oct 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 23, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 23, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 23, 2023

PR approved by anyone and no changes requested.

@doris-robot
Copy link
Copy Markdown

doris-robot commented Oct 23, 2023

TeamCity be ut coverage result:
Function Coverage: 37.03% (8298/22410)
Line Coverage: 29.17% (66618/228359)
Region Coverage: 27.79% (34610/124544)
Branch Coverage: 24.41% (17577/72012)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f53bd97112c0355a5b61daee7aab1e8ebba0ae02_f53bd97112c0355a5b61daee7aab1e8ebba0ae02/report/index.html

@doris-robot
Copy link
Copy Markdown

doris-robot commented Oct 23, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.09 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162151458 Bytes

dataroaring
dataroaring approved these changes Oct 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchen zhannngchen merged commit ed85c44 into apache:master Oct 23, 2023
xiaokang pushed a commit that referenced this pull request Oct 24, 2023
@bobhan1 @xiaokang
[Fix](partial update) Fix wrong comment in .proto file (#25742)
fe97a17 
1. remove deprecated comment on fields that is wrongly added in #25147. These fields will be used when coordinator BE send infos to executor BEs. They will only be used during RPC and will not be persisted.
2. eliminate some unnecessary copys.
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@bobhan1
[Fix](partial update) Fix wrong comment in .proto file (apache#25742)
cc8a30a 
1. remove deprecated comment on fields that is wrongly added in apache#25147. These fields will be used when coordinator BE send infos to executor BEs. They will only be used during RPC and will not be persisted.
2. eliminate some unnecessary copys.
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@bobhan1
[Fix](partial update) Fix wrong comment in .proto file (apache#25742)
4a0d498 
1. remove deprecated comment on fields that is wrongly added in apache#25147. These fields will be used when coordinator BE send infos to executor BEs. They will only be used during RPC and will not be persisted.
2. eliminate some unnecessary copys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liaoxin01 liaoxin01 liaoxin01 approved these changes

@zhannngchen zhannngchen zhannngchen approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged merge_conflict reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bobhan1 @doris-robot @liaoxin01 @zhannngchen @dataroaring @xiaokang