[Enhancement](grouping) Add a switch for users to force using alias name in group by and having clause#15748
Merged
morningman merged 8 commits intoapache:masterfrom Jan 31, 2023
Merged
Conversation
github-actions
bot
added
the
area/planner
xy720
changed the title
Contributor
|
TeamCity pipeline, clickbench performance test result: |
Member
|
add a regression test |
Contributor
|
Please update variables.md doc |
13 tasks
xy720
force-pushed
the
add-swith-for-alias-first
branch
from
d50566d to
2c23154
Compare
github-actions
bot
added
kind/docs
Member
Author
|
Update docs and add regression test |
xy720
force-pushed
the
add-swith-for-alias-first
branch
4 times, most recently
from
396419d to
fd464ac
Compare
xy720
force-pushed
the
add-swith-for-alias-first
branch
3 times, most recently
from
7ca6494 to
ce956ab
Compare
13 tasks
morningman
reviewed
Jan 30, 2023
| } | ||
|
|
||
| substituteOrdinalsAliases(groupingExprs, "GROUP BY", analyzer, false); | ||
| boolean aliasFirst = ConnectContext.get().getSessionVariable().isGroupByAndHavingUseAliasFirst(); |
Contributor
There was a problem hiding this comment.
The ConnectContext.get() may be null when replaying edit log
xy720
force-pushed
the
add-swith-for-alias-first
branch
from
2e4cda6 to
1a6e9fc
Compare
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
englefly
pushed a commit
to englefly/incubator-doris
that referenced
this pull request
Feb 1, 2023
…ame in group by and having clause (apache#15748)
dutyu
pushed a commit
to dutyu/doris
that referenced
this pull request
Feb 1, 2023
…ame in group by and having clause (apache#15748)
dutyu
pushed a commit
to dutyu/doris
that referenced
this pull request
Feb 6, 2023
…ame in group by and having clause (apache#15748)
5 tasks
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
Apr 25, 2024
this variable intro by apache#15748 for backward compatibility. currently, it is used very infrequently. Nereids do not support it anymore. So, we tag it as deprecated, and will remove it future.
morrySnow
added a commit
that referenced
this pull request
Apr 26, 2024
) this variable intro by #15748 for backward compatibility. currently, it is used very infrequently. Nereids do not support it anymore. So, we tag it as deprecated, and will remove it in the future.
dataroaring
pushed a commit
that referenced
this pull request
Apr 27, 2024
) this variable intro by #15748 for backward compatibility. currently, it is used very infrequently. Nereids do not support it anymore. So, we tag it as deprecated, and will remove it in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #15747
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...