[refactor](schema change) Using tablet schema shared ptr instead of raw ptr#11475
Merged
yiguolei merged 27 commits intoapache:masterfrom Aug 5, 2022
Merged
[refactor](schema change) Using tablet schema shared ptr instead of raw ptr#11475yiguolei merged 27 commits intoapache:masterfrom
yiguolei merged 27 commits intoapache:masterfrom
Conversation
Contributor
|
Have you done a stress test to see whether this is a performance drop for this pr? |
Contributor
Author
No, because tablet schema is only used in control path, it is not on data path. And there will be a nightly performance benchmark in selectdb. If we find performance drops we could revert this PR. |
Contributor
|
LGTM |
Contributor
Author
|
@wangbo I have done a simple performance test.
compare current branch with a47eff1 commit. |
beff0f3 to
2f46cde
Compare
2f46cde to
86a1e95
Compare
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is part of light weight schema change #10136
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...