(performance)[scanner] Isolate local and remote queries using different scanner…#11006
Merged
dataroaring merged 8 commits intoapache:masterfrom Jul 29, 2022
Merged
Conversation
luwei16
changed the title
luwei16
changed the title
pengxiangyu
reviewed
Jul 21, 2022
| // number of s3 scanner thread pool size | ||
| CONF_Int32(doris_s3_scanner_thread_pool_thread_num, "48"); | ||
| // number of s3 scanner thread pool queue size | ||
| CONF_Int32(doris_s3_scanner_thread_pool_queue_size, "102400"); |
|
|
||
| // TODO(cmy): find a better way to unify these 2 pools. | ||
| PriorityThreadPool* _scan_thread_pool = nullptr; | ||
| PriorityThreadPool* _s3_scan_thread_pool = nullptr; |
Contributor
There was a problem hiding this comment.
_s3_scan_thread_pool need to be _remote_scan_thread_pool
Contributor
|
PR approved by anyone and no changes requested. |
morningman
approved these changes
Jul 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem Summary:
Scanner thread pool shared by remote data and local data query. The high latency of remote data query will occupy the thread pool worker thread and affect the performance of local data query.
Therefore, a remote scanner thread pool for remote data query is added to avoid the impact on local query.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...