Cleanup regex_expressions.rs to remove _regexp_match function #9107
Merged
alamb merged 5 commits intoapache:mainfrom Feb 3, 2024
Merged
Cleanup regex_expressions.rs to remove _regexp_match function #9107alamb merged 5 commits intoapache:mainfrom
alamb merged 5 commits intoapache:mainfrom
Conversation
alamb
approved these changes
Feb 2, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
@viirya fixed the problem in #8631
I ran some of the queries from that PR:
❯ SELECT COUNT(*) FROM 'index' WHERE
ARRAY_LENGTH(
REGEXP_MATCH(path, '\\.(asm|c|cc|cpp|cxx|h|hpp|rs|[Ff][0-9]{0,2}(?:or)?|go)$')
) > 0;on 7.2 GB of parquet data
$ du -s -h index
7.2G index
Main (without this PR):
1 row in set. Query took 4.820 seconds.
This PR:
1 row in set. Query took 4.760 seconds.
So basically the same.
Thank you @Omega359 -- very nice cleanup 🧹
viirya
reviewed
Feb 2, 2024
viirya
reviewed
Feb 2, 2024
viirya
reviewed
Feb 2, 2024
viirya
approved these changes
Feb 2, 2024
Removed extraneous line as per code review suggestion Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
Removed extraneous lines as per code review Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9106
Rationale for this change
Code cleanup.
What changes are included in this PR?
Code removal, minor code cleanup, toml file updates.
Are these changes tested?
Yes
Are there any user-facing changes?
No.